Re: [PATCH 19/73] mtools: Fix build with uclibc

Khem Raj
2016-01-18T21:51:41Z

[-- Attachment #1: Type: text/plain, Size: 1961 bytes --]

Hi Roman

> On Jan 17, 2016, at 11:17 PM, Roman Khimov <roman@khimov.ru> wrote:
>
> В письме от 17 января 2016 03:35:52 пользователь Khem Raj написал:
>> --- a/meta/recipes-devtools/mtools/mtools_4.0.18.bb
>> +++ b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
>> @@ -5,6 +5,7 @@ SECTION = "optional"
>> LICENSE = "GPLv3"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>>
>> +DEPENDS += "virtual/libiconv"
>>
>> RDEPENDS_${PN}_libc-glibc = "glibc-gconv-ibm850"
>> RRECOMMENDS_${PN}_libc-glibc = "\
>> @@ -35,6 +36,8 @@ inherit autotools texinfo
>>
>> EXTRA_OECONF = "--without-x"
>>
>> +LDFLAGS_append_libc-uclibc = " -liconv "
>> +
>> BBCLASSEXTEND = "native nativesdk"
>>
>> PACKAGECONFIG ??= ""
>
> I've just checked to see that my mtools bbappend (based on fido) has it solved
> like this:
>
> DEPENDS_class-target += "virtual/libiconv"
> export LIBS = "-liconv"
> LIBS_class-native = “"

Both are doing same thing in the end. if LIBS is altered we inject the compiler flags
same happens via LDFLAGS except that if we use LDFLAGS then we can utilize overrides
at recipe level and they are automatically exported into component Make systems.

LIBS is supposed to be computed during configure if one was to use libs approach
then USERLDLIBS is safer.

>
> And from what I remember, I had some issue building native package with
> 'DEPENDS +='. Although that's an old branch and probably things are different
> now.

I guess what you might have seen is that there is no provider for libiconv-native
which is already fixed by
https://github.com/kraj/openembedded-core/commit/a5e6f5939c0ee4280eabd7cfc01131052040bc81

if it was something else. Please report with more details.

>
> Same thing with parted.
>
> --
> http://roman.khimov.ru
> mailto: roman@khimov.ru
> gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]