Re: [OE-core] Patchtest results for [PATCH 2/2] systemd: remove custom rootlibexecdir and replace with nonarch_base_libdir

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2024-11-29 at 18:23 -0800, Khem Raj via lists.openembedded.org
wrote:
> 
> 
> On Fri, Nov 29, 2024 at 10:58 AM Ricardo Salveti via
> lists.openembedded.org
> <ricardo.salveti=oss.qualcomm.com@lists.openembedded.org> wrote:
> > On Fri, Nov 29, 2024 at 12:46 AM
> > <patchtest@automation.yoctoproject.org> wrote:
> > > 
> > > Thank you for your submission. Patchtest identified one
> > > or more issues with the patch. Please see the log below for
> > > more information:
> > > 
> > > ---
> > > Testing patch /home/patchtest/share/mboxes/2-2-systemd-remove-
> > > custom-rootlibexecdir-and-replace-with-nonarch_base_libdir.patch
> > > 
> > > FAIL: test max line length: Patch line too long (current length
> > > 224, maximum is 200)
> > > (test_metadata.TestMetadata.test_max_line_length)
> > 
> > Caused by:
> > 
> > -               $INTERCEPT_DIR/postinst_intercept update_udev_hwdb
> > ${PKG} mlprefix=${MLPREFIX} binprefix=${MLPREFIX}
> > rootlibexecdir="${rootlibexecdir}"
> > PREFERRED_PROVIDER_udev="${PREFERRED_PROVIDER_udev}"
> > base_bindir="${base_bindir}"
> > +               $INTERCEPT_DIR/postinst_intercept update_udev_hwdb
> > ${PKG} mlprefix=${MLPREFIX} binprefix=${MLPREFIX}
> > rootlibexecdir="${nonarch_base_libdir}"
> > PREFERRED_PROVIDER_udev="${PREFERRED_PROVIDER_udev}"
> > base_bindir="${base_bindir}"
> > 
> > Didn't want to break that line as part of the change as this is
> > basically a sed.
> > 
> > Can break and send a v2 if needed.
> > 
> 
> 
> Perhaps send a separate patch since it’s a formatting improvement 
> 

I think it is fine. The check is there to stop people introducing
really long lines if we can help it but this already exists and
personally, I find it hard to get worked up about line length...

Cheers,

Richard