From: Paul Barker <paul@pbarker.dev>
To: Angel2Eyes <thefireking@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] oeqa/selftest: add fs-uuid.bbclass coverage
Date: Mon, 21 Sep 2026 09:26:15 +0100 [thread overview]
Message-ID: <af30a5dc9e588d52d44d73a1c1c00996976083f3.camel@pbarker.dev> (raw)
In-Reply-To: <20260919181900.443-1-thefireking@gmail.com>
On Sat, 2026-09-19 at 21:19 +0300, Angel2Eyes wrote:
> The class has had no tests since it was added. Load the live helpers
> and cover tune2fs UUID parsing, placeholder replacement used by
> syslinux/grub/systemd-boot, and a real ext image when e2fsprogs is
> present.
>
> [YOCTO #15020]
>
> AI-Generated: Cursor Grok 4.6
Hi,
Please review the existing test cases for an understanding of how we
typically do things in OE-core selftests. Mocking out the bitbake
datastore & bb module, reading a bbclass file in and calling
exec(compile()), etc are not things we usually do and require further
explanation for why they are needed.
As mentioned in the description of the bug [1], the way forward is
probably to move the functions from fs-uuid.bbclass into a Python module
under lib/oe. That should allow simpler testing as a second patch.
[1]: https://bugzilla.yoctoproject.org/show_bug.cgi?id=15020
Best regards,
--
Paul Barker
prev parent reply other threads:[~2026-09-21 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 18:19 [OE-core][PATCH] oeqa/selftest: add fs-uuid.bbclass coverage Angel2Eyes
2026-09-21 8:26 ` Paul Barker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af30a5dc9e588d52d44d73a1c1c00996976083f3.camel@pbarker.dev \
--to=paul@pbarker.dev \
--cc=openembedded-core@lists.openembedded.org \
--cc=thefireking@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox