Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Yash Shinde <Yash.Shinde@windriver.com>
To: Khem Raj <raj.khem@gmail.com>, alex.kanavin@gmail.com
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>,
	"MacLeod, Randy" <randy.macleod@windriver.com>,
	"Kokkonda, Sundeep" <Sundeep.Kokkonda@windriver.com>
Subject: Re: [OE-core] [RFC] rust: Upgrade 1.85.1->1.86.0
Date: Fri, 30 May 2025 18:12:02 +0530	[thread overview]
Message-ID: <afaa4102-c876-437a-871d-f6f90697d5f4@windriver.com> (raw)
In-Reply-To: <7571c07b-2225-4449-8169-08b044208072@gmail.com>


On 30-05-2025 08:02, Khem Raj wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender 
> and know the content is safe.
>
> On 5/27/25 9:26 AM, Alexander Kanavin via lists.openembedded.org wrote:
>> On Tue, 27 May 2025 at 16:42, Yash Shinde <Yash.Shinde@windriver.com> 
>> wrote:
>>> Yeah, that's the reason.
>>>
>>> I am not sure how rust-lld is installed in ${D} now. A similar error 
>>> was
>>> previously resolved by using:
>>> "+TARGET_CC_ARCH +=
>>> "${LDFLAGS}""(https://git.yoctoproject.org/poky/commit/?id=cc24a0ff76f2e227cc3a0f478d078b2158299a80) 
>>>
>>>
>>> LDFLAGS are explicitly unset in rust recipe.
>>> (https://git.yoctoproject.org/poky/tree/meta/recipes-devtools/rust/rust_1.85.1.bb#n194) 
>>>
>>> I attempted to remove the "unset LDFLAGS" in rust recipe and exported
>>> TARGET_CC_ARCH as above, but that didn't work.
>>>
>>> Is there some different or recommended way to pass LDFLAGS to rust that
>>> I might be missing?
>>
>> The issue isn't about how to pass LDFLAGS. The issue is that something
>> triggers building all these additional things, including rust-lld, and
>> you need to narrow down how and where that happens, and how to go back
>> to the install set (and build times) we've had in 1.85. Please get to
>> the particular point where that decision happens.
>>
>> We can't just double the build times without a comprehensive,
>> convincing investigation.
>>
>
> Try adding
>
> [rust]
> lld = false
>
> to config.toml, but lld might speed up rust packages themselves. So
> perhaps this should be capped under a packageconfig or such, provided
> this works.
>
I investigated the commit histroy between 1.85.1 and 1.86 and found few 
commits related
to building a "self-contained" LLD (rust-lld)as part of rust bootstrap 
build.
This results additional installations during the builds.

Here are the commits and PRs:

https://github.com/rust-lang/rust/pull/135001
https://github.com/rust-lang/rust/commit/8744b44e6bde053f7656a3c727c968177ee8e4b6

Additionally, there's ongoing development to make LLD as the default 
linker for x86_64-unknown-linux-gnu.
https://github.com/rust-lang/rust/pull/140525

As Khem mentioned, setting lld = false in config.toml doesn't build LLD.
Furthermore, using "use-lld = false" ensures that LLD is not used as the 
default linker,
causing the build to fall back to the system's default linker. This 
restores the earlier behavior.
Also, the package QA error for rust-lld is not seen with this.

Regards,
Yash


>> Alex
>>
>


  reply	other threads:[~2025-05-30 12:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 16:22 [RFC] rust: Upgrade 1.85.1->1.86.0 Yash Shinde
2025-05-27 12:47 ` [OE-core] " Alexander Kanavin
     [not found] ` <184363192F51E64D.13855@lists.openembedded.org>
2025-05-27 13:40   ` Alexander Kanavin
2025-05-27 14:40     ` Yash Shinde
2025-05-27 14:06 ` Alexander Kanavin
2025-05-27 14:42   ` Yash Shinde
2025-05-27 16:26     ` Alexander Kanavin
2025-05-30  2:32       ` Khem Raj
2025-05-30 12:42         ` Yash Shinde [this message]
2025-05-30 13:15           ` Alexander Kanavin
2025-06-02 11:15             ` Yash Shinde
2025-06-02 13:03               ` Randy MacLeod
2025-06-02 17:09                 ` Khem Raj
2025-06-03 18:31                   ` Randy MacLeod
2025-06-03 20:56                     ` Khem Raj
2025-06-06 12:50                     ` Yash Shinde
2025-06-06 12:57                       ` Yash Shinde
2025-06-03 19:14               ` Randy MacLeod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afaa4102-c876-437a-871d-f6f90697d5f4@windriver.com \
    --to=yash.shinde@windriver.com \
    --cc=Sundeep.Kokkonda@windriver.com \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=randy.macleod@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox