Re: [OE-core] [[PATCHv2] meta: Add pam to DISTRO_FEATURES if using systemd

["Jörg Sommer" <joerg.sommer@navimatix.de>]

[-- Attachment #1: Type: text/plain, Size: 2902 bytes --]

Leon Anavi via lists.openembedded.org schrieb am Di 07. Jul, 12:02 (+0300):
> Add pam to the list of DISTRO_FEATURES in init-manager-systemd.inc.
> This way pam will available if variable VIRTUAL-RUNTIME_init_manager
> has been set to systemd. Otherwise having systemd in conjunction
> with wayland but without pam leads to a conflict with the
> REQUIRED_DISTRO_FEATURES for weston related recipes.
> 
> This adjustment is required following these recent changes that
> switched VIRTUAL-RUNTIME_init_manager to systemd by default and added
> wayland to DISTRO_FEATURES_DEFAULTS which affects "nodistro":
> 
> - 159148f4de2595556fef6e8678578df83383857b
>   meta: Support opting out of any distro features
>   (Please note that this commit also extended DISTRO_FEATURES_DEFAULTS
>   with wayland and vulkan.)
> 
> - 0b4061c5d50261f826d0edb4b478d2d305274b7c
>   conf: Switch to systemd by default and simplify init manager selection
> 
> This fixes issues with test_machine_world when running the
> yocto-check-layer script for BSP layers that include weston in the
> dependency chain, for example meta-tegra:
> 
> ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'l4t-graphics-demos', 'weston']
> 
> The weston recipe has pam in REQUIRED_DISTRO_FEATURES if systemd is
> enabled. Therefore, it makes sense to also add pam to the defaults
> through DISTRO_FEATURES in init-manager-systemd.inc.
> 
> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> ---
>  meta/conf/distro/include/init-manager-systemd.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/conf/distro/include/init-manager-systemd.inc b/meta/conf/distro/include/init-manager-systemd.inc
> index 63fd225ca5..2e9eef24b5 100644
> --- a/meta/conf/distro/include/init-manager-systemd.inc
> +++ b/meta/conf/distro/include/init-manager-systemd.inc
> @@ -1,5 +1,5 @@
>  # Use systemd for system initialization
> -DISTRO_FEATURES:append = " systemd usrmerge"
> +DISTRO_FEATURES:append = " systemd usrmerge pam"

systemd and usrmerge are required features for systemd. But pam is optional
and should be in DISTRO_FEATURES_DEFAULTS to allow for easy opt-out.

On the other side: Is pam so much common that it should be enabled by
default? Why not leave this decision to the distro or the local.conf when
the user selects the content of the image?


Kind regards, Jörg

>  VIRTUAL-RUNTIME_init_manager ??= "systemd"
>  VIRTUAL-RUNTIME_initscripts ??= ""
>  VIRTUAL-RUNTIME_login_manager ??= "shadow-base"
> -- 
> 2.47.3
> 

-- 
Navimatix GmbH           T: 03641 - 327 99 0
Tatzendpromenade 2       F: 03641 - 526 306
07745 Jena               www.navimatix.de

Geschäftsführer: Steffen Späthe, Jan Rommeley
Registergericht: Amtsgericht Jena, HRB 501480

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 6684 bytes --]