From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: is it best practice to use ${sysconfdir} rather than hard-coding "/etc"?
Date: Sat, 30 Jun 2012 09:41:25 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1206300940100.18253@oneiric> (raw)
In-Reply-To: <20120630132935.GA3689@jama.jama.net>
On Sat, 30 Jun 2012, Martin Jansa wrote:
> On Sat, Jun 30, 2012 at 09:25:57AM -0400, Robert P. J. Day wrote:
> >
> > i suspect i know the answer to this, but in the recipe file
> > usbinit.bb, we have:
> >
> > do_install() {
> > install -d ${D}/etc
> > install -d ${D}/etc/init.d
> > install usb-gether ${D}/etc/init.d
> > }
> >
> > i'm guessing that would more properly be coded:
> >
> > do_install() {
> > install -d ${D}${sysconfdir}
> > install -d ${D}${sysconfdir}/init.d
> > install usb-gether ${D}${sysconfdir}/init.d
> > }
> >
> > the end result is functionally identical, of course, it's all just a
> > matter of style.
>
> using sysconfdir is better as someone can define it to different value
> then 'etc' and the later will still work (be consistent across image)
there are definitely a number of examples of hard-coded "/etc" in
the recipes, but i'm not about to run around cleaning them -- i just
wanted to make sure there was no compelling reason to do that
hard-coding. thanks.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2012-06-30 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 13:25 is it best practice to use ${sysconfdir} rather than hard-coding "/etc"? Robert P. J. Day
2012-06-30 13:29 ` Martin Jansa
2012-06-30 13:41 ` Robert P. J. Day [this message]
2012-06-30 14:45 ` Mark Hatle
2012-06-30 14:34 ` Andrei Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1206300940100.18253@oneiric \
--to=rpjday@crashcourse.ca \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox