From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from astoria.ccjclearline.com ([64.235.106.9]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SlezE-0006ud-8B for openembedded-core@lists.openembedded.org; Mon, 02 Jul 2012 13:40:12 +0200 Received: from cpec03f0ed08c7f-cm001ac318e826.cpe.net.cable.rogers.com ([99.241.91.63]:50330 helo=crashcourse.ca) by astoria.ccjclearline.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.77) (envelope-from ) id 1Sleoa-0005U0-AI for openembedded-core@lists.openembedded.org; Mon, 02 Jul 2012 07:29:12 -0400 Date: Mon, 2 Jul 2012 07:29:08 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@oneiric To: Patches and discussions about the oe-core layer In-Reply-To: <1341219932.23146.187.camel@ted> Message-ID: References: <1341219932.23146.187.camel@ted> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - astoria.ccjclearline.com X-AntiAbuse: Original Domain - lists.openembedded.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Subject: Re: is the PRIORITY variable actually used anywhere? X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2012 11:40:12 -0000 Content-Type: TEXT/PLAIN; charset=US-ASCII On Mon, 2 Jul 2012, Richard Purdie wrote: > On Sat, 2012-06-30 at 06:20 -0400, Robert P. J. Day wrote: > > On Sat, 30 Jun 2012, Martin Jansa wrote: > > > > > http://git.openembedded.org/meta-openembedded/commit/?id=040f75eca217c79fed7b881589d9bb36358cffe1 > > > http://git.openembedded.org/openembedded-core/commit/?id=d122343362669c683acc4af295971a62cbc823fc > > > > > > so can be dropped from bitbake.conf too AFAIK > > > > actually, there are still a number of lines that refer to that > > variable: > > > > $ grep -rw PRIORITY * > > meta/conf/bitbake.conf:PRIORITY = "optional" > > meta/conf/documentation.conf:PRIORITY[doc] = "Importance of package, default values are 'optional' or 'needed'." > > meta/classes/package_deb.bbclass: fields.append(["Priority: %s\n", ['PRIORITY']]) > > meta/classes/package_ipk.bbclass: fields.append(["Priority: %s\n", ['PRIORITY']]) > > meta/classes/oelint.bbclass: # Test for valid PRIORITY > > meta/classes/oelint.bbclass: s = testVar("PRIORITY") > > meta/classes/oelint.bbclass: bb.note("PRIORITY '%s' is not recommended" % s) > > meta/classes/oelint.bbclass: bb.note("PRIORITY '%s' is not recommended, better use '%s'" % (s, newprio)) > > meta/classes/oelint.bbclass: bb.note("PRIORITY '%s' is not recommended" % s) > > meta/classes/oelint.bbclass: bb.error("PRIORITY should only use lower case") > > $ > > > > if i can assume that all of that can be removed, i can do that as a > > single patch, again unless someone else wants to handle it if there > > are subtleties involved. > > I think this one is best left alone as the code stands. We did remove > the variable from standard usage, it doesn't obsolete the above code > which someone could in theory still use from say a distro configuration > perspective. > > The line in documentation.conf look wrong though, I think "needed" > should be "required". oelint.bbclass currently suggests it can be any of "standard", "required", "optional" or "extra". and perhaps a dumb question -- how are there *two* default values? not sure what that means. anyway, i'll leave this in someone else's capable hands. it's pretty obvious that no use is being made of this variable these days. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================