From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: setting EXTRA_IMAGE_FEATURES explicitly in .bb file can screw things up
Date: Sun, 8 Jul 2012 14:06:18 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1207081405290.28471@oneiric> (raw)
In-Reply-To: <alpine.DEB.2.02.1207071435090.25344@oneiric>
On Sat, 7 Jul 2012, Robert P. J. Day wrote:
> a while back, i whined about the inconsistent usage of
> EXTRA_IMAGE_FEATURES, like this as a snippet:
>
> meta/recipes-sato/images/core-image-sato-sdk.bb:EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
> meta/recipes-rt/images/core-image-rt-sdk.bb:EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
> meta/recipes-extended/images/core-image-lsb-sdk.bb:EXTRA_IMAGE_FEATURES = "tools-debug tools-profile tools-testapps debug-tweaks"
>
> notice the mixing of "+=" and "=", which seems messy. then i ran
> across this in core-image-lsb-sdk.bb:
>
> IMAGE_FEATURES += "apps-console-core tools-sdk dev-pkgs ssh-server-openssh"
> EXTRA_IMAGE_FEATURES = "tools-debug tools-profile tools-testapps debug-tweaks"
>
> that *can't* be right, can it? the explicit setting of
> EXTRA_IMAGE_FEATURES in that recipe file will override any such
> setting in one's local.conf file, won't it? and that's how the
> current manual *advises* how to add more features through your
> local.conf.
>
> i tested this target with a standard local.conf, and checked the
> environment to see:
>
> ... snip ...
> IMAGE_FEATURES="apps-console-core debug-tweaks tools-sdk
> tools-testapps dev-pkgs tools-profile tools-debug ssh-server-openssh"
>
> which looks fine according to the .bb file.
>
> but if i add the following to my local.conf file (as the manual
> suggests i do to add another feature):
>
> EXTRA_IMAGE_FEATURES = "nfs-server"
>
> i see *no* difference in the environment. hasn't the setting in the
> .bb file overridden the one in my local.conf?
>
> i *can* get nfs-server added to my list of features with
> (predictably):
>
> IMAGE_FEATURES += "nfs-server"
>
> but that doesn't strike me as a proper solution and will certainly
> come as an unpleasant surprise to someone eventually.
i'm still curious if this is a potential issue, or whether i'm just
misreading/misunderstanding. thoughts?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2012-07-08 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-07 18:52 setting EXTRA_IMAGE_FEATURES explicitly in .bb file can screw things up Robert P. J. Day
2012-07-08 18:06 ` Robert P. J. Day [this message]
2012-07-09 8:59 ` Andrei Gherzan
2012-07-09 15:24 ` Robert P. J. Day
2012-07-09 15:30 ` Paul Eggleton
2012-07-09 16:25 ` Robert P. J. Day
2012-07-09 20:32 ` Andrei Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1207081405290.28471@oneiric \
--to=rpjday@crashcourse.ca \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox