Re: [PATCH 3/3] oelint.bbclass: Check for ${PN} or ${P} usage

["Robert P. J. Day" <rpjday@crashcourse.ca>]

On Fri, 1 Aug 2014, Chong Lu wrote:

> Check for ${PN} or ${P} usage in SRC_URI or S.
> We should use ${BPN} or ${BP} instead to avoid breaking multilib.
>
> [YOCTO #5427]
>
> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> ---
>  meta/classes/oelint.bbclass | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/meta/classes/oelint.bbclass b/meta/classes/oelint.bbclass
> index 0bed74a..685a88d 100644
> --- a/meta/classes/oelint.bbclass
> +++ b/meta/classes/oelint.bbclass
> @@ -62,4 +62,24 @@ python do_lint() {
>                      bb.warn("${PN}: %s doesn't have Signed-off-by" % item)
>                  if findKey(path, "Upstream-Status"):
>                      bb.warn("${PN}: %s doesn't have Upstream-Status" % item)
> +
> +
> +    ##############################
> +    # Check for ${PN} or ${P} usage in SRC_URI or S
> +    # Should use ${BPN} or ${BP} instead to avoid breaking multilib
> +    #
> +    s = d.getVar("SRC_URI").split()
> +
> +    for srcurl in s:
> +        if not srcurl.startswith("file://"):
> +            if not srcurl.find("{PN}") == -1:
> +                bb.warn("${PN}: Should use BPN instead to PN in SRC_URI")
> +            if not srcurl.find("{P}") == -1:

  should you not say, "use BPN instead of PN ..."?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================