Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: questions about WORKDIR and S usage and files/ stuff
Date: Sun, 22 Feb 2015 03:35:51 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.11.1502220334160.12252@localhost> (raw)
In-Reply-To: <1424522044.11836.70.camel@linuxfoundation.org>

On Sat, 21 Feb 2015, Richard Purdie wrote:

> On Sat, 2015-02-21 at 05:09 -0500, Robert P. J. Day wrote:

... snip ...

> >   sticking with those non-patch files, it makes sense that all of
> > them should be processed relative to their location in ${WORKDIR}
> > (which is where they've all been copied), but occasionally, i'll
> > see a recipe that sets:
> >
> >   S = ${WORKDIR}
> >
> > then refers to all those files relative to ${S}. sure, that'll
> > work, but it always struck me as dangerous in case you ever need
> > to use a separate S directory down the road, then you'd have to
> > change the entire recipe.
> >
> >   as an example, consider base-files again, which sets:
> >
> >   S = "${WORKDIR}"
> >
> > but not for any reason that i can see since that recipe consists
> > of nothing but explicit files, and all of their processing is done
> > with respect to ${WORKDIR}, anyway, which strikes me as the right
> > way to do it. so, a question -- what is the point of the
> > base-files recipe setting S to that value? doesn't seem to have
> > any purpose that i can see.
>
> See the recent patches which actually added that.

  sorry, i don't know what recent patches you're talking about ...
that variable setting above has, according to git blame, been part of
the base-files recipe since back in 2005.

  what am i misunderstanding?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================


  parent reply	other threads:[~2015-02-22  8:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-21 10:09 questions about WORKDIR and S usage and files/ stuff Robert P. J. Day
2015-02-21 12:34 ` Richard Purdie
2015-02-21 20:18   ` Robert P. J. Day
2015-02-21 20:28   ` Robert P. J. Day
2015-02-22  8:35   ` Robert P. J. Day [this message]
2015-02-22  8:54     ` Richard Purdie
2015-02-22  9:00       ` Robert P. J. Day
2015-02-22 20:25       ` Robert P. J. Day
2015-02-23  9:24         ` Paul Eggleton
2015-02-23 10:02           ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.11.1502220334160.12252@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox