From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: why does sysfsutils-2.1.0.bb set S = "${WORKDIR}/sysfsutils-${PV}"?
Date: Mon, 26 Oct 2015 06:40:28 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.20.1510260637410.21382@localhost> (raw)
In-Reply-To: <11124457.9F2LW3uP4S@peggleto-mobl.ger.corp.intel.com>
On Mon, 26 Oct 2015, Paul Eggleton wrote:
> On Monday 26 October 2015 06:23:09 Robert P. J. Day wrote:
> > On Fri, 23 Oct 2015, Paul Eggleton wrote:
> >
> > ... me snipped ...
> >
> > > I don't think so, it appears that line goes way back to the initial
> > > population of the repository. Looks like we could just drop it.
> >
> > it *looks* like there are a number of lines like that in oe-core
> > that are superfluous ... some samples (which i have not verified, i
> > just selected from brief visual inspection):
> >
> > recipes-bsp/hostap/hostap-utils.inc:S = "${WORKDIR}/hostap-utils-${PV}"
> > recipes-bsp/pcmciautils/pcmciautils.inc:S = "${WORKDIR}/pcmciautils-${PV}"
> > recipes-connectivity/openssl/openssl.inc:S = "${WORKDIR}/openssl-${PV}"
> > recipes-core/sysvinit/sysvinit_2.88dsf.bb:S = "${WORKDIR}/sysvinit-${PV}"
> > recipes-core/glib-2.0/glib.inc:S = "${WORKDIR}/glib-${PV}"
> > recipes-core/sysfsutils/sysfsutils_2.1.0.bb:S =
> > "${WORKDIR}/sysfsutils-${PV}" recipes-devtools/mtools/mtools_3.9.9.bb:S =
> > "${WORKDIR}/mtools-${PV}" recipes-devtools/intltool/intltool.inc:S =
> > "${WORKDIR}/intltool-${PV}" recipes-devtools/git/git.inc:S =
> > "${WORKDIR}/git-${PV}"
> > recipes-extended/psmisc/psmisc.inc:S = "${WORKDIR}/psmisc-${PV}"
> > recipes-extended/net-tools/net-tools_1.60-26.bb:S =
> > "${WORKDIR}/net-tools-1.60"
> > recipes-gnome/gtk+/gtk+3_3.16.6.bb:S =
> > "${WORKDIR}/gtk+-${PV}"
> > recipes-kernel/oprofile/oprofile_1.1.0.bb:S = "${WORKDIR}/oprofile-${PV}"
> > recipes-multimedia/libid3tag/libid3tag_0.15.1b.bb:S =
> > "${WORKDIR}/libid3tag-${PV}" ... etc etc ...
> >
> > and probably lots more. do i have at least the right understanding
> > that any setting of S which eventally equates to
> > ${WORKDIR}/${BPN}-${PV} serves no useful purpose? (not sure about
> > *-native recipes, though, i have to take a closer look at those to see
> > if they fit the pattern.)
>
> Now, you really need to be careful with this - in some cases these
> files are included from other recipes where PN is not the same as it
> would be in the standard recipe; there it is deliberate and
> "cleaning it up" would actually break the other recipe. Additionally
> I can see above, net-tools isn't a candidate because the version
> part is not the same ("1.60" vs "1.60-26"). Every recipe will need
> to be checked.
oh, i realize this ... i did say that this was a very cursory list i
hadn't checked carefully yet. i may or may not do any of this cleanup,
i just wanted to make sure i was at least understanding the occasional
redundancy correctly.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
prev parent reply other threads:[~2015-10-26 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 12:02 why does sysfsutils-2.1.0.bb set S = "${WORKDIR}/sysfsutils-${PV}"? Robert P. J. Day
2015-10-23 12:49 ` Paul Eggleton
2015-10-23 12:57 ` Robert P. J. Day
2015-10-23 13:08 ` Paul Eggleton
2015-10-26 10:23 ` Robert P. J. Day
2015-10-26 10:34 ` Paul Eggleton
2015-10-26 10:40 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1510260637410.21382@localhost \
--to=rpjday@crashcourse.ca \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox