Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Khem Raj <raj.khem@gmail.com>
Cc: Christopher Larson <clarson@kergoth.com>,
	OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: should a "*git.bb" recipe lock that recipe to a fixed version?
Date: Mon, 31 Oct 2016 02:29:43 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.20.1610310223510.6909@localhost.localdomain> (raw)
In-Reply-To: <F99EA06D-E6DA-4FD4-BBED-D10D157F200C@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2059 bytes --]

On Sun, 30 Oct 2016, Khem Raj wrote:

>       On Oct 30, 2016, at 4:36 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 30 October 2016 at 17:35, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>         fair enough ... i'm embarrassed to admit i didn't really understand
>       the versioning selection so i'm going to examine it way more carefully
>       now. i wonder how many recipes in oe-core are "_git" recipes that, in
>       the end, just lock down to a specific version. as you say, i was a bit
>       surprised.
>
> Personally I've been endorsing the practise where _git.bb is only
> used for recipes that are actually tracking git development
> branches, and if it's just a release that it simply fetched over git
> via a SHA of a release tag then the recipe should be _1.2.3.bb for
> clarity.
>
> with a system integrators hat on I agree. With developer hat on I do not.

khem:

  could you expand on that? now that i understand how the versioning
works, i'll be more careful in the future, but it's still misleading
for a "_git"-named recipe file to be locked to a particular version.

  AFAICT, there are plenty of OE recipes that download via git, but
are still named as being version locked. eg, here's
meta/recipes-devtools/file/file_5.28.bb:

  SRC_URI = "git://github.com/file/file.git \
        file://debian-742262.patch \
        file://0001-Add-P-prompt-into-Usage-info.patch \
        "

  SRCREV = "3c521817322a6bf5160cfeb09b9145ccde587b2a"

i'm assuming that that particular SRCREV corresponds to release
version 5,28, so that makes perfect sense.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

  reply	other threads:[~2016-10-31  6:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-30 12:25 should a "*git.bb" recipe lock that recipe to a fixed version? Robert P. J. Day
2016-10-30 17:16 ` Christopher Larson
2016-10-30 17:35   ` Robert P. J. Day
2016-10-30 23:36     ` Burton, Ross
2016-10-31  2:54       ` Khem Raj
2016-10-31  6:29         ` Robert P. J. Day [this message]
2016-10-31 16:31           ` Khem Raj
2016-10-30 19:40   ` Christopher Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.20.1610310223510.6909@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=clarson@kergoth.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox