From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cpanel7.indieserve.net (cpanel7.indieserve.net [199.212.143.8]) by mx.groups.io with SMTP id smtpd.web12.8032.1586004745947986164 for ; Sat, 04 Apr 2020 05:52:26 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: crashcourse.ca, ip: 199.212.143.8, mailfrom: rpjday@crashcourse.ca) Received: from cpeac202e043973-cmac202e043970.sdns.net.rogers.com ([174.114.100.179]:52106 helo=localhost.localdomain) by cpanel7.indieserve.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jKiHg-002hDl-Ae; Sat, 04 Apr 2020 08:52:25 -0400 Date: Sat, 4 Apr 2020 08:52:22 -0400 (EDT) From: "rpjday@crashcourse.ca" X-X-Sender: rpjday@localhost.localdomain To: Richard Purdie cc: OE Core mailing list Subject: Re: [OE-core] [PATCH] bin_package.bbclass: emphasize setting of S with "subdir" In-Reply-To: Message-ID: References: MIME-Version: 1.0 X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel7.indieserve.net X-AntiAbuse: Original Domain - lists.openembedded.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Get-Message-Sender-Via: cpanel7.indieserve.net: authenticated_id: rpjday+crashcourse.ca/only user confirmed/virtual account not confirmed X-Authenticated-Sender: cpanel7.indieserve.net: rpjday@crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Content-Type: text/plain; charset=US-ASCII On Sat, 4 Apr 2020, Richard Purdie wrote: > On Sat, 2020-04-04 at 08:00 -0400, rpjday@crashcourse.ca wrote: > > Clarify the setting of "S" so there is absolutely no confusion. > > > > Signed-off-by: Robert P. J. Day > > > > --- > > > > diff --git a/meta/classes/bin_package.bbclass b/meta/classes/bin_package.bbclass > > index cbc9b1fa13..4e74557967 100644 > > --- a/meta/classes/bin_package.bbclass > > +++ b/meta/classes/bin_package.bbclass > > @@ -14,8 +14,8 @@ > > # > > # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" > > # > > -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, otherwise > > -# they would be in ${WORKDIR}. > > +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, otherwise > > +# they would be in S=${WORKDIR}. > > # > > I strongly disagree actually. Setting subdir in SRC_URI does not change > the value of S. What happens is what the comment says, its unpacked to > ${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at whatever > its set to. oh, i didn't realize that, my mistake. i could have sworn ... rday