From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cpanel7.indieserve.net (cpanel7.indieserve.net [199.212.143.8]) by mx.groups.io with SMTP id smtpd.web10.7588.1587248256474737359 for ; Sat, 18 Apr 2020 15:17:37 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: crashcourse.ca, ip: 199.212.143.8, mailfrom: rpjday@crashcourse.ca) Received: from cpef81d0f814063-cmf81d0f814060.cpe.net.cable.rogers.com ([174.114.57.56]:52976 helo=localhost.localdomain) by cpanel7.indieserve.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jPvmI-004FyH-5N; Sat, 18 Apr 2020 18:17:34 -0400 Date: Sat, 18 Apr 2020 18:17:31 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Christopher Larson cc: Peter Kjellerstedt , "chris.laplante@agilent.com" , Richard Purdie , OE Core mailing list Subject: Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"? In-Reply-To: Message-ID: References: MIME-Version: 1.0 X-OutGoing-Spam-Status: No, score=1.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel7.indieserve.net X-AntiAbuse: Original Domain - lists.openembedded.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Get-Message-Sender-Via: cpanel7.indieserve.net: authenticated_id: rpjday+crashcourse.ca/only user confirmed/virtual account not confirmed X-Authenticated-Sender: cpanel7.indieserve.net: rpjday@crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Content-Type: multipart/mixed; boundary="8323328-1498845375-1587248254=:571354" --8323328-1498845375-1587248254=:571354 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Sat, 18 Apr 2020, Christopher Larson wrote: > On Apr 18, 2020, 1:10 PM -0700, Robert P. J. Day , wrote: > On Sat, 18 Apr 2020, Peter Kjellerstedt wrote: > > -----Original Message----- > From: openembedded-core@lists.openembedded.org core@lists.openembedded.org> On Behalf Of Robert P. J. Day > Sent: den 18 april 2020 19:24 > To: chris.laplante@agilent.com > Cc: Richard Purdie ; OE Core mailing > list > Subject: Re: [OE-core] why does oe-buildenv-internal check for -z > "$BDIR"? > > On Sat, 18 Apr 2020, chris.laplante@agilent.com wrote: > > i know that -- in fact, it's the only way i use it > -- the question > is the purpose for checking if $BDIR is zero length > first. that is, > under what circumstances could it *not* be? even > invoking the way you > demonstrate, that variable is empty when tested, > and i see nothing > that could cause it to have a value before that > test. > > > FWIW I was curious/bored and looked to see if 'BDIR' was ever > used > in poky (outside of the script of course), and I found no > results. > > git rev-list --all | xargs git grep -w BDIR -- './*' > ':!scripts/oe- > > buildenv-internal' > > that's kind of the point i was making ... that variable appeared out > of nowhere, clearly seemed like a local variable, and is even "unset" > after it's used in that script. i poked around, trying to figure if > there was some other flow of control that got you into that script > from another direction, but i didn't find one. > > and, yes, it seems trivial to obsess over it, but it's just those > sorts of things that make me wonder, "hmmmmm ... maybe i *don't* > really understand how this script can be used." > > anyway, moving on ... > > rday > > > When it comes to understanding why the code looks like it does in a > case like this, it is often better to look at the history than the > current state. > > If you go back to when the test was introduced (commit > 5d5fab77cf9616bf62023c202b38f309f8bbf189 in Poky), you will see that > BDIR could be set in a script called poky-autobuild at that time. > The poky-autobuild script was removed 12 years ago, but the test in > oe-buildenv-internal remained. > > > additional observation, but same script also contains: > > if [ -n "$2" ]; then > BITBAKEDIR="$2" > fi > > clearly implying a second argument pointing at bitbake directory, > which is nowhere documented, and is followed by: > > if [ -z "$BITBAKEDIR" ]; then > BITBAKEDIR="$OEROOT/bitbake$BBEXTRA" > test -d "$BITBAKEDIR" || BITBAKEDIR="$OEROOT/../bitbake$BBEXTRA" > fi > > this also seems out of date, but i won't flog it any further.  > > > > I don’t think this is out of date. It’s allowing the user to specify > the path to bitbake (which I’ve done in unusual layouts or just to > be explicit), falling back to either under OEROOT (poky-style) or in > its parent (more typical). > > It’s also worth noting that oe-init-build-env and > oe-buildenv-internal are not just used directly, but many other > setup scripts build on top of them, so this particular flexibility > is useful. BDIR still seems like it can be dropped regardless of the > BITBAKEDIR logic. that actually matches with what i concluded -- BDIR is dead and gone, but i realized that BITBAKEDIR could still be useful, even if it's currently undocumented. so i'll submit a patch to ditch BDIR, and leave all else as is. for now. rday --8323328-1498845375-1587248254=:571354--