From: "Sinan Kaya" <okaya@kernel.org>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [meta-oe][PATCH v4] iproute2: split ip to individual package
Date: Wed, 16 Dec 2020 20:58:32 -0500 [thread overview]
Message-ID: <b0203c25-a954-795e-406c-d46f503c9efa@kernel.org> (raw)
In-Reply-To: <c3075328cf4d45ecb2ae76bdbeeae4cc@XBOX03.axis.com>
On 12/16/2020 8:20 PM, Peter Kjellerstedt wrote:
>> I do something very similar in my bbappend now. On the other hand, we
>> have an upstream first principle in the company. I would rather try to
>> find an upstream friendly solution that works for everybody without
>> breaking existing users before falling back to bbappend route that I
>> need to maintain forever.
> Well, the problem as I see it is that some of these changes are pretty
> invasive to the recipes. And when most seem fine with them as they are
> (based on the fact that there has not been any push to split any of
> them before AFAIK), the value of these changes are questionable, given
> that more complicated recipes increase the maintenance burden.
>
The counter argument is that a user should not be required to rework a
recipe in bbappend for common tools that everybody uses the same way.
If I was doing something special for my target, it has no business in
upstream recipe.
Requesting to have the ip tool out of iproute2 package is a no-brainer
IMO and should be supported by default.
I can also go ahead and say that ip tool probably is the most important
tool in this package and is actually disappointing to see that it has
not been brought out either by PACKAGECONFIG or PACKAGE options. I
honestly don't care about the rest of the tools in that package.
At the end of the day, there is room for improvement in the recipe.
Whether we can do it safely or not is for reviewers to help here.
prev parent reply other threads:[~2020-12-17 1:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 17:50 [meta-oe][PATCH v4] iproute2: split ip to individual package Sinan Kaya
2020-12-16 23:19 ` [OE-core] " Peter Kjellerstedt
2020-12-17 0:30 ` Sinan Kaya
2020-12-17 1:20 ` Peter Kjellerstedt
2020-12-17 1:58 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0203c25-a954-795e-406c-d46f503c9efa@kernel.org \
--to=okaya@kernel.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox