From: Jack Mitchell <ml@embed.me.uk>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] cmake.bbclass: avoid treating imports as system includes
Date: Wed, 7 Sep 2016 10:56:41 +0100 [thread overview]
Message-ID: <b22d48a3-3fb3-5ee2-3351-e94e30480511@embed.me.uk> (raw)
In-Reply-To: <1473198083-19785-1-git-send-email-schnitzeltony@googlemail.com>
On 06/09/16 22:41, Andreas Müller wrote:
> CMake sets all imported headers as system headers. This causes trouble for c++
> projects [1].
>
> Thanks to Jack Mitchell for pointing to the setting [2]. Build tested upon
> meta-qt5-extra-world which had lots of fallout before.
>
> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
> [2] http://lists.openembedded.org/pipermail/openembedded-core/2016-September/126067.html
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
> meta/classes/cmake.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
> index 5203d8a..7091f8b 100644
> --- a/meta/classes/cmake.bbclass
> +++ b/meta/classes/cmake.bbclass
> @@ -120,6 +120,7 @@ cmake_do_configure() {
> -DCMAKE_INSTALL_SO_NO_EXE=0 \
> -DCMAKE_TOOLCHAIN_FILE=${WORKDIR}/toolchain.cmake \
> -DCMAKE_VERBOSE_MAKEFILE=1 \
> + -DCMAKE_NO_SYSTEM_FROM_IMPORTED=1 \
> ${EXTRA_OECMAKE} \
> -Wno-dev
> }
>
This is cleaner than my implementation.
Acked By: Jack Mitchell <jack@embed.me.uk>
prev parent reply other threads:[~2016-09-07 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 21:41 [PATCH] cmake.bbclass: avoid treating imports as system includes Andreas Müller
2016-09-07 9:56 ` Jack Mitchell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b22d48a3-3fb3-5ee2-3351-e94e30480511@embed.me.uk \
--to=ml@embed.me.uk \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox