From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Armin Kuster <akuster808@gmail.com>,
akuster@mvista.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] os-release: add more variables to list
Date: Thu, 25 Oct 2018 10:25:17 +0100 [thread overview]
Message-ID: <b2dd231dcb644b0c97082d64abc7dfd703ef6d95.camel@linuxfoundation.org> (raw)
In-Reply-To: <1540452055-22743-1-git-send-email-akuster808@gmail.com>
On Thu, 2018-10-25 at 08:20 +0100, Armin Kuster wrote:
> If someone extends the OS_RELEASE_FIELDS in a bbappend, it will cause
> the hash to change which is
> caught by the yocto-check-layer
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
> meta/recipes-core/os-release/os-release.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/os-release/os-release.bb
> b/meta/recipes-core/os-release/os-release.bb
> index 7f3d9cb..88bf8f8 100644
> --- a/meta/recipes-core/os-release/os-release.bb
> +++ b/meta/recipes-core/os-release/os-release.bb
> @@ -12,7 +12,7 @@ do_configure[noexec] = "1"
>
> # Other valid fields: BUILD_ID ID_LIKE ANSI_COLOR CPE_NAME
> # HOME_URL SUPPORT_URL BUG_REPORT_URL
> -OS_RELEASE_FIELDS = "ID ID_LIKE NAME VERSION VERSION_ID PRETTY_NAME"
> +OS_RELEASE_FIELDS = "ID ID_LIKE NAME VERSION VERSION_ID PRETTY_NAME BUILD_ID HOME_URL BUG_REPORT_URL SUPPORT_URL CPE_NAME"
I'm not sure I agree with this. It would usually be a policy decision,
e.g. a ditro config which would change this and you'd not be doing this
with a bbappend?
Cheers,
Richard
next prev parent reply other threads:[~2018-10-25 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 7:20 [PATCH] os-release: add more variables to list Armin Kuster
2018-10-25 9:25 ` Richard Purdie [this message]
2018-10-28 18:24 ` akuster808
2018-10-29 17:12 ` richard.purdie
2018-10-29 19:36 ` akuster808
2018-10-29 21:10 ` richard.purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2dd231dcb644b0c97082d64abc7dfd703ef6d95.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=akuster808@gmail.com \
--cc=akuster@mvista.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox