public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: paul@pbarker.dev, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 10/12] libsdl2: Explicitly set PACKAGECONFIG vardeps
Date: Wed, 18 Mar 2026 17:29:17 +0000	[thread overview]
Message-ID: <b2f33df7c4ca8457f34482ab5ce8bc1b1a9c5c7d.camel@linuxfoundation.org> (raw)
In-Reply-To: <20260318-fix-checklayer-2-v1-10-388ba6ce47cd@pbarker.dev>

On Wed, 2026-03-18 at 17:14 +0000, Paul Barker via lists.openembedded.org wrote:
> The variable dependencies are discarded for PACKAGECONFIG, which may
> cause tasks which use the value of PACKAGECONFIG to be considered
> arch-independent, even when the value is actually different depending on
> the target architecture.
> 
> In this case, we use the value of TUNE_FEATURES in PACKAGECONFIG, which
> is obviously arch-dependent so we should explicitly list this
> dependency.
> 
> Signed-off-by: Paul Barker <paul@pbarker.dev>
> ---
>  meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb
> index 834cf096b977..f7c292b6adb0 100644
> --- a/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb
> +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb
> @@ -80,6 +80,9 @@ PACKAGECONFIG[vulkan]    = "-DSDL_VULKAN=ON,-DSDL_VULKAN=OFF"
>  PACKAGECONFIG[wayland]    = "-DSDL_WAYLAND=ON,-DSDL_WAYLAND=OFF,wayland-native wayland wayland-protocols libxkbcommon"
>  PACKAGECONFIG[x11]        = "-DSDL_X11=ON,-DSDL_X11=OFF,virtual/libx11 libxext libxrandr libxrender"
>  
> +# PACKAGECONFIG dependencies are not automatically carried forwards
> +PACKAGECONFIG[vardeps] += "TUNE_FEATURES"

I'm not understanding the issue here.

I added a vardepvalue for PACKAGECONFIG but the usage of TUNE_FEATURES
here shouldn't matter, the expanded value will differ and that should
be all we need for the taskhashes to work properly.

What issue are you trying to solve here?

Cheers,

Richard



  reply	other threads:[~2026-03-18 17:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 17:14 [PATCH 00/12] Further check-layer fixes Paul Barker
2026-03-18 17:14 ` [PATCH 01/12] checklayer: Fix regex in get_signatures Paul Barker
2026-03-18 17:14 ` [PATCH 02/12] curl: Drop arch dependent search paths Paul Barker
2026-03-18 17:14 ` [PATCH 03/12] ghostscript: " Paul Barker
2026-03-18 17:14 ` [PATCH 04/12] libssh2: " Paul Barker
2026-03-18 17:14 ` [PATCH 05/12] flac: Use arch independent search path Paul Barker
2026-03-18 17:14 ` [PATCH 06/12] gettext: Use arch independent search paths Paul Barker
2026-03-18 17:14 ` [PATCH 07/12] gnutls: " Paul Barker
2026-03-18 17:14 ` [PATCH 08/12] initscripts: Make SRC_URI arch independent Paul Barker
2026-03-18 17:22   ` [OE-core] " Richard Purdie
2026-03-18 17:14 ` [PATCH 09/12] linux-yocto: Avoid arch dependent vardeps for SRC_URI Paul Barker
2026-03-18 17:14 ` [PATCH 10/12] libsdl2: Explicitly set PACKAGECONFIG vardeps Paul Barker
2026-03-18 17:29   ` Richard Purdie [this message]
2026-03-18 17:14 ` [PATCH 11/12] graphene: " Paul Barker
2026-03-18 17:14 ` [PATCH 12/12] gstreamer1.0-plugins-good: " Paul Barker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2f33df7c4ca8457f34482ab5ce8bc1b1a9c5c7d.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul@pbarker.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox