Re: [OE-core] [PATCH v10] Rust Oe-Selftest implementation

Richard Purdie
2022-09-07T15:07:55Z

On Wed, 2022-09-07 at 20:34 +0530, pgowda cve wrote:
> Hi Richard,
>
> Thanks for pointing this out and your help in improving the patch.
> I am using an Ubuntu-18.04 machine and am not able to see the error.
>
> > > Something is mangling spaces in your patch. There shouldn't be tabs here.
> Fixed.
>
> > > I think this can be merged with the RustSelfTestBase class as I don't
> Merged.
>
> > > If we want to change grammar, it should be in a separate patch.
> Removed it.

Thanks for tweaking these.

>
> > > addtask do_test_compile after do_configure do_rust_gen_targets
> > > put that alongside the task definition.
> Added along with addtask definition.

I clearly wasn't clear enough!

It should be next to where the task is defined in rust_1.63.0.bb, i.e.
alongside the do_test_compile task definition itself.

Cheers,

Richard