From: Saul Wold <sgw@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: Jingdong Lu <jingdong.lu@windriver.com>
Subject: [CONSOLIDATED PULL 12/12] libx11: fix libX11 keysyms to pass xts5 of lsb
Date: Thu, 2 Jun 2011 01:05:11 -0700 [thread overview]
Message-ID: <b31d66b5395b40740d2e28128dcd51c66e2495fd.1307001679.git.sgw@linux.intel.com> (raw)
In-Reply-To: <cover.1307001679.git.sgw@linux.intel.com>
In-Reply-To: <cover.1307001679.git.sgw@linux.intel.com>
From: Jingdong Lu <jingdong.lu@windriver.com>
Fixes bug: [YOCTO #1095]
Because of cross-compiling libx11 keysyms will cause Xts5 test of LSB fail.
libx11 use a tool named "makekey" which compiled as a native tool to generate
ks_tables.h. Because the size of "unsigned long" is different between 32-bit
and 64-bit, we should judge whether our target is 32-bit or 64-bit and tell
"makekey".
I add a patch to "makekeys_crosscompile.patch" to "src/utils/makekeys.c" in
order to deal with the different targets. If our target is 32-bit, we force
the variable its type is "unsigned long" to "uint32_t". So we can generate a
correct keysyms.
Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com>
---
.../libx11-1.3.4/makekeys_crosscompile.patch | 45 ++++++++++++++++++++
.../recipes-graphics/xorg-lib/libx11-trim_1.3.4.bb | 5 +-
meta/recipes-graphics/xorg-lib/libx11.inc | 8 +++-
meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb | 5 +-
4 files changed, 58 insertions(+), 5 deletions(-)
create mode 100644 meta/recipes-graphics/xorg-lib/libx11-1.3.4/makekeys_crosscompile.patch
diff --git a/meta/recipes-graphics/xorg-lib/libx11-1.3.4/makekeys_crosscompile.patch b/meta/recipes-graphics/xorg-lib/libx11-1.3.4/makekeys_crosscompile.patch
new file mode 100644
index 0000000..e5eacf0
--- /dev/null
+++ b/meta/recipes-graphics/xorg-lib/libx11-1.3.4/makekeys_crosscompile.patch
@@ -0,0 +1,45 @@
+Because the size of "unsigned long" is different between 32-bit
+and 64-bit, judge whether target is 32-bit or 64-bit and tell
+"makekey".
+
+Upstream-Status: Pending
+
+Signed-off-by: dbuitenh@windriver.com
+
+--- libX11-1.3.4.orig/src/util/makekeys.c 2010-01-15 09:11:36.000000000 +0800
++++ libX11-1.3.4/src/util/makekeys.c 2011-05-24 19:04:25.454774908 +0800
+@@ -33,6 +33,7 @@
+ #include <X11/keysymdef.h>
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <stdint.h>
+
+ typedef unsigned long Signature;
+
+@@ -124,7 +125,12 @@
+ name = info[i].name;
+ sig = 0;
+ while ((c = *name++))
+- sig = (sig << 1) + c;
++#ifdef USE32
++ sig = (uint32_t)(sig << 1) + c;
++#else
++ sig = (uint64_t)(sig << 1) + c;
++#endif
++
+ first = j = sig % z;
+ for (k = 0; tab[j]; k++) {
+ j += first + 1;
+@@ -163,7 +169,11 @@
+ name = info[i].name;
+ sig = 0;
+ while ((c = *name++))
+- sig = (sig << 1) + c;
++#ifdef USE32
++ sig = (uint32_t)(sig << 1) + c;
++#else
++ sig = (uint64_t)(sig << 1) + c;
++#endif
+ first = j = sig % z;
+ while (offsets[j]) {
+ j += first + 1;
diff --git a/meta/recipes-graphics/xorg-lib/libx11-trim_1.3.4.bb b/meta/recipes-graphics/xorg-lib/libx11-trim_1.3.4.bb
index b013498..1469bc1 100644
--- a/meta/recipes-graphics/xorg-lib/libx11-trim_1.3.4.bb
+++ b/meta/recipes-graphics/xorg-lib/libx11-trim_1.3.4.bb
@@ -5,12 +5,13 @@ DESCRIPTION += " Support for XCB, and XCMS is disabled in this version."
LICENSE = "MIT & MIT-style & BSD"
LIC_FILES_CHKSUM = "file://COPYING;md5=bf75bfe4d05068311b5e6862d4b5f2c5"
-PR = "r0"
+PR = "r1"
DEPENDS += "libxcb xproto xextproto xtrans libxau kbproto inputproto xf86bigfontproto xproto-native"
SRC_URI += "file://../libx11-${PV}/x11_disable_makekeys.patch \
file://../libx11-${PV}/include_fix.patch \
- file://../libx11-${PV}/nodolt.patch"
+ file://../libx11-${PV}/nodolt.patch \
+ file://../libx11-${PV}/makekeys_crosscompile.patch"
EXTRA_OECONF += "--disable-xcms --with-xcb"
diff --git a/meta/recipes-graphics/xorg-lib/libx11.inc b/meta/recipes-graphics/xorg-lib/libx11.inc
index 030b0db..c156ce6 100644
--- a/meta/recipes-graphics/xorg-lib/libx11.inc
+++ b/meta/recipes-graphics/xorg-lib/libx11.inc
@@ -6,6 +6,8 @@ basic functions of the window system."
require xorg-lib-common.inc
+inherit siteinfo
+
PROVIDES = "virtual/libx11"
XORG_PN = "libX11"
@@ -22,7 +24,11 @@ do_compile() {
touch makekeys-makekeys.o
(
unset CC LD CXX CCLD CFLAGS CPPFLAGS LDFLAGS CXXFLAGS
- ${BUILD_CC} ${BUILD_CFLAGS} -I${STAGING_INCDIR_NATIVE} makekeys.c -o makekeys
+ if [ "${SITEINFO_BITS}" == "64" ]; then
+ ${BUILD_CC} ${BUILD_CFLAGS} -I${STAGING_INCDIR_NATIVE} makekeys.c -o makekeys
+ else
+ ${BUILD_CC} ${BUILD_CFLAGS} -I${STAGING_INCDIR_NATIVE} -DUSE32 makekeys.c -o makekeys
+ fi
)
if [ "$?" != "0" ]; then
exit 1
diff --git a/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb b/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb
index 08ba07b..3e046a1 100644
--- a/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb
+++ b/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb
@@ -5,11 +5,12 @@ LICENSE = "MIT & MIT-style & BSD"
LIC_FILES_CHKSUM = "file://COPYING;md5=bf75bfe4d05068311b5e6862d4b5f2c5"
PE = "1"
-PR = "r0"
+PR = "r1"
SRC_URI += "file://x11_disable_makekeys.patch \
file://nodolt.patch \
- file://include_fix.patch"
+ file://include_fix.patch \
+ file://makekeys_crosscompile.patch"
SRC_URI[md5sum] = "f65c9c7ecbfb64c19dbd7927160d63fd"
SRC_URI[sha256sum] = "88d7238ce5f7cd123450567de7a3b56a43556e4ccc45df38b8324147c889a844"
--
1.7.3.4
next prev parent reply other threads:[~2011-06-02 8:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 8:04 [CONSOLIDATED PULL 00/12] 2-June-2011 Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 01/12] m4: upgrade from 1.4.15 to 1.4.16 Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 02/12] autoconf: upgrade from 2.65 to 2.68 Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 03/12] bison: upgrade from 2.4.3 to 2.5 Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 04/12] gettext-0.16.1: mark upstream status for gplv2 recipe's patches Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 05/12] u-boot: package up u-boot.bin for field upgrades Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 06/12] shadow: remove selinux entry from pam.d/login Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 07/12] rootfs_ipk: delete opkg metadata if package management not required and all packages are configured Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 08/12] avahi: enable service when using systemd Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 09/12] ghostscript: Fix up file locations and add i686 Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 10/12] gcc: Fix volatile access issue for ARM Saul Wold
2011-06-02 8:05 ` [CONSOLIDATED PULL 11/12] task-core-lsb: add cups and ghostscript into image Saul Wold
2011-06-02 8:05 ` Saul Wold [this message]
2011-06-02 13:50 ` [CONSOLIDATED PULL 00/12] 2-June-2011 Richard Purdie
2011-06-02 14:57 ` Saul Wold
2011-06-02 15:03 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31d66b5395b40740d2e28128dcd51c66e2495fd.1307001679.git.sgw@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=jingdong.lu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox