Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Jacob Kroon <jacob.kroon@gmail.com>
To: Mark Hatle <mark.hatle@kernel.crashing.org>,
	openembedded-core@lists.openembedded.org,
	Joshua Watt <JPEW.hacker@gmail.com>
Subject: Re: [PATCH v2] base-passwd: Add kvm group
Date: Tue, 22 Oct 2019 08:38:53 +0200	[thread overview]
Message-ID: <b46b712e-b2a7-15b9-c79b-3262595f50dd@gmail.com> (raw)
In-Reply-To: <55271782-4edd-6591-3d5a-12bd071a0940@gmail.com>

Forgot to mention, the number chosen for the kvm group, 47, I just 
picked one of the available slots, no further reasoning behind that choice.

/Jacob

On 10/22/19 8:32 AM, Jacob Kroon wrote:
> Hi Joshua, Mark,
> 
>>> In general, I don't think we should be "patching in" users and groups
>>> like this to base-passwd. If upstream doesn't have them, they need to
>>> be added through the normal useradd.bbclass mechanism so that users of
>>> useradd-staticids can choose what ID they get mapped to.
>>>
>>> Is it possible to revert this and add the kvm group via the 
>>> useradd.bbclass?
>>>
>>>>
>>>>    udevd[<pid>]: specified group 'kvm' unknown
>>
>> As for this particular patch, why is adding a specific KVM group 
>> required?
>> Unless something is hardcoded in KVM to use group '47', a regular 
>> system type
>> useradd call should be done instead.  This would avoid the problem 
>> that Joshua
>> is experiencing.
>>
> 
> The groups "shutdown" and "input" were already patched in in the same 
> way, so I figured that was the way to do it. But it sounds like you're 
> pointing out that we can drop those three patches, and instead use 
> useradd.bbclass in base-passwd recipe ? Sounds like a nice cleanup.
> 
> Cheers,
> Jacob


      reply	other threads:[~2019-10-22  6:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04  3:11 [PATCH v2] base-passwd: Add kvm group Jacob Kroon
2019-05-11  7:21 ` Jacob Kroon
2019-05-12  8:19   ` Richard Purdie
2019-10-21 17:03 ` Joshua Watt
2019-10-21 17:23   ` Mark Hatle
2019-10-21 17:42     ` Joshua Watt
2019-10-21 18:51       ` Mark Hatle
2019-10-22  6:32     ` Jacob Kroon
2019-10-22  6:38       ` Jacob Kroon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b46b712e-b2a7-15b9-c79b-3262595f50dd@gmail.com \
    --to=jacob.kroon@gmail.com \
    --cc=JPEW.hacker@gmail.com \
    --cc=mark.hatle@kernel.crashing.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox