Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [CONSOLIDATED PULL 01/17] cml1.bbclass: Only delay exit if the command fails
Date: Fri, 22 Jun 2012 15:00:42 -0700	[thread overview]
Message-ID: <b6748ff02cd7d4433894571b42533edf4ac6a541.1340402353.git.sgw@linux.intel.com> (raw)
In-Reply-To: <cover.1340402353.git.sgw@linux.intel.com>
In-Reply-To: <cover.1340402353.git.sgw@linux.intel.com>

From: Darren Hart <dvhart@linux.intel.com>

Rather than pause for 5 seconds, test the return code of the command and
require user input before exiting on failure. This avoids pausing after
successful command execution as well as possibly not waiting long enough
if the user happens to be doing something else for 5 seconds.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---
 meta/classes/cml1.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index fd80c18..67f17ad 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -20,7 +20,7 @@ python do_menuconfig() {
         except OSError:
             mtime = 0
 
-        oe_terminal("${SHELL} -c \"make menuconfig; echo 'Pausing for 5 seconds'; sleep 5\"", '${PN} Configuration', d)
+        oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; echo -n 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
 
         # FIXME this check can be removed when the minimum bitbake version has been bumped
         if hasattr(bb.build, 'write_taint'):
-- 
1.7.7.6




  reply	other threads:[~2012-06-22 22:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22 22:00 [CONSOLIDATED PULL 00/17] Misc Fixes & Updates Saul Wold
2012-06-22 22:00 ` Saul Wold [this message]
2012-06-22 22:00 ` [CONSOLIDATED PULL 02/17] runqemu-internal: qemu fails to run on ext2 image Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 03/17] mtd-utils: do not stage headers in sysroot Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 04/17] gpgme: updated to 1.3.2 Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 05/17] gcc-4.6: Retire into toochain-layer Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 06/17] eglibc-2.13: Retire into toolchain layer Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 07/17] gcc: Remove csl gcc recipes Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 08/17] gzip: upgrade to 1.5 Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 09/17] sudo: upgrade to 1.8.5p2 Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 10/17] bitbake.conf/abi_version.conf: Update to use BasicHash signature generator Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 11/17] linux-firmware: update to main repo on kernel.org Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 12/17] kconfig-frontends: New recipe Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 13/17] uclibc: Fix packaging to match the new package order Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 14/17] qemu.inc: Fix packageconfig options Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 15/17] qemu-git: Move to tip of git Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 16/17] qemu_git: set empty PACKAGECONFIG Saul Wold
2012-06-22 22:00 ` [CONSOLIDATED PULL 17/17] distrodata: Fix missed VARIABLE name change Saul Wold
2012-06-24 18:18 ` [CONSOLIDATED PULL 00/17] Misc Fixes & Updates Saul Wold
2012-06-25 15:55 ` Richard Purdie
2012-06-25 21:14   ` Khem Raj
2012-06-29 12:26     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6748ff02cd7d4433894571b42533edf4ac6a541.1340402353.git.sgw@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox