From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kernel.crashing.org (kernel.crashing.org [76.164.61.194]) by mx.groups.io with SMTP id smtpd.web11.9135.1585752606983654875 for ; Wed, 01 Apr 2020 07:50:07 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=permerror, err=syntax error for token: (domain: kernel.crashing.org, ip: 76.164.61.194, mailfrom: mark.hatle@kernel.crashing.org) Received: from Marks-MacBook-Pro-16.local ([76.164.61.198]) (authenticated bits=0) by kernel.crashing.org (8.14.7/8.14.7) with ESMTP id 031EnqwI012486 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 1 Apr 2020 09:49:58 -0500 Subject: Re: [OE-core] [PATCH 2/5] archiver.bbclass: Make do_deploy_archives a recursive dependency To: Paul Barker , Richard Purdie Cc: openembedded-core@lists.openembedded.org References: <20200309142139.15741-1-pbarker@konsulko.com> <20200309142139.15741-3-pbarker@konsulko.com> <20200311114028.31344b22@ub1910> From: "Mark Hatle" Message-ID: Date: Wed, 1 Apr 2020 09:49:52 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200311114028.31344b22@ub1910> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit (I know this is an old thread, but I ran into this as well..) ... On 3/11/20 6:40 AM, Paul Barker wrote: > On Tue, 10 Mar 2020 23:18:33 +0000 > Richard Purdie wrote: > >> On Mon, 2020-03-09 at 14:21 +0000, Paul Barker wrote: >>> To ensure that archives are captured for all dependencies of a typical >>> bitbake build we add do_deploy_archives to the list of recursive >>> dependencies of do_build. Without this, archives may be missed for >>> recipes such as gcc-source which do not create packages or populate a >>> sysroot. >>> >>> do_deploy_archives is also added to the recursive dependencies of >>> do_populate_sdk so that all sources required for an SDK can be captured. >>> >>> Signed-off-by: Paul Barker >>> --- >>> meta/classes/archiver.bbclass | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass >>> index fef7ad4f62..c11d36d708 100644 >>> --- a/meta/classes/archiver.bbclass >>> +++ b/meta/classes/archiver.bbclass >>> @@ -604,7 +604,9 @@ addtask do_ar_configured after do_unpack_and_patch >>> addtask do_ar_mirror after do_fetch >>> addtask do_dumpdata >>> addtask do_ar_recipe >>> -addtask do_deploy_archives before do_build >>> +addtask do_deploy_archives >>> +do_build[recrdeptask] += "do_deploy_archives" >>> +do_populate_sdk[recrdeptask] += "do_deploy_archives" >> >> We implemented the --runall option to bitbake to try and avoid having >> recrdeptask versions of most tasks. Does that not work here? It should >> also work for the SDK I think? You can't use a --runall operation on a task target, such as: bitbake core-image-minimal -c populate_sdk I can't find any way to get all of the archiver sources for the populate_sdk target. The above should resolve this, and as Paul said below it will ensure that populate_sdk follows the same behavior as regular image generation as well. I'm wondering if do_populate_sdk_ext needs it as well. > If the archiver is enabled, its tasks should be in the dependency tree of > whatever you're building so that you don't need to invoke bitbake twice to > produce the required artifacts. For images that's the way the archiver has > always worked, if it's enabled then you just need to do `bitbake image` to > build the image and deploy the source archives. This change just extends that > behaviour to cover other things we can build and ensures that we don't miss > sources for recipes like gcc-source. >