Re: [OE-core] [PATCH v7] Rust Oe-Selftest implementation

[Randy MacLeod <randy.macleod@windriver.com>]

On 2022-08-03 10:28, Pgowda wrote:
> Hi Luca,
>
> Updated the maintainers list and submitted the patch as:-
> https://lists.openembedded.org/g/openembedded-core/message/168819
>
> Thanks,
> Pgowda

Thanks Naveen.

For future follow-ups on this thread and when there is more than
one version, it's good to provide a brief cover letter / section that 
explains
what has changed since the last version. eg:

https://lists.openembedded.org/g/openembedded-core/message/167252?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Acreated%2C0%2CV3+%2Fproc%2Fpressure+buildstats%2C20%2C1%2C0%2C91929131


See:

https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded

and part of:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

We don't require this but for large patches that have several 
iterations, it's
very helpful for the sender to summarize what has changed so that the 
gatekeeper
doesn't have to dig up the previous patch.

Thanks,

../Randy

>
> On Wed, Aug 3, 2022 at 7:13 PM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>> Hi Pgowda,
>>
>> On Wed, 3 Aug 2022 15:40:15 +0200
>> "Luca Ceresoli via lists.openembedded.org"
>> <luca.ceresoli=bootlin.com@lists.openembedded.org> wrote:
>>
>>> On Tue,  2 Aug 2022 17:50:05 +0530
>>> "Pgowda" <pgowda.cve@gmail.com> wrote:
>>>
>>>> From: pgowda <pgowda.cve@gmail.com>
>>>>
>>>> The patch implements Rust testing framework similar to other selftest,
>>>> specifically the gcc selftest in OE. It uses the client and server
>>>> based method to test the binaries for cross-target on the image.
>>>> The test framework is a wrapper around the Rust build system as ./x.py
>>>> test.
>>>> It tests many functionalities of Rust distribution like tools,
>>>> documentation, libraries, packages, tools, Cargo, Crater etc.
>>>> Please refer the following link for detailed description of Rust
>>>> testing:-
>>>> https://rustc-dev-guide.rust-lang.org/tests/intro.html#tool-tests
>>>>
>>>> To support the rust tests in oe-core, the following functions were
>>>> added:-
>>>> setup_cargo_environment(): Build bootstrap and some early stage tools.
>>>> do_rust_setup_snapshot(): Install the snapshot version of rust binaries.
>>>> do_configure(): To generate config.toml
>>>> do_compile(): To build "remote-test-server" for qemu target image.
>>>>
>>>> Approximate Number of Tests Run in the Rust Testsuite :- 18000
>>>> Approximate Number of Tests that FAIL in bitbake environment :- 100-150
>>>> Normally majority of the testcases are present in major folder "test/"
>>>> It contributes to more than 80% of the testcases present in Rust test
>>>> framework. These tests pass as expected on any Rust versions without
>>>> much fuss. The tests that fail are of less important and contribute to
>>>> less than 2% of the total testcases. These minor tests are observed to
>>>> work on some versions and fail on others. They have to be added, ignored
>>>> or excluded for different versions as per the behavior.
>>>> These tests have been ignored or excluded in the Rust selftest
>>>> environment to generate success of completing the testsuite.
>>>>
>>>> These tests work in parallel mode even in the skipped test mode as
>>>> expected. Although the patch to disable tests is large, it is very simple
>>>> in that it only disables tests. When updating to a newer version of Rust,
>>>> the patch can usually be ported in a day.
>>>>
>>>> Signed-off-by: pgowda <pgowda.cve@gmail.com>
>>>> Signed-off-by: Vinay Kumar <vinay.m.engg@gmail.com>
>>> This patch fails because of:
>>>
>>>    AssertionError:
>>>    The following recipes do not have a maintainer assigned to them. Please add an entry to meta/conf/distro/include/maintainers.inc file.
>>>    rust-testsuite (/home/pokybuild/yocto-worker/oe-selftest-centos/build/meta/recipes-devtools/rust/rust-testsuite_1.62.0.bb)
>>>
>>> Some logs:
>>>
>>> https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3917/steps/15/logs/stdio
>>> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3866/steps/14/logs/stdio
>> ...and there is another failure, this time it is an actual build error:
>>
>> | CMake Error at /home/pokybuild/yocto-worker/qemux86-64/build/build-st-789666/tmp/work/core2-64-poky-linux/rust-testsuite/1.62.0-r0/recipe-sysroot-native/usr/share/cmake-3.23/Modules/CMakeTestCXXCompiler.cmake:62 (message):
>> |   The C++ compiler
>> |
>> |     "/home/pokybuild/yocto-worker/qemux86-64/build/build-st-789666/tmp/work/core2-64-poky-linux/rust-testsuite/1.62.0-r0/wrapper/build-rust-cxx"
>> |
>> |   is not able to compile a simple test program.
>> |
>> |   It fails with the following output:
>> |
>> [...]
>> |     /home/pokybuild/yocto-worker/qemux86-64/build/build-st-789666/tmp/hosttools/ld: cannot find -lstdc++
>> |     collect2: error: ld returned 1 exit status
>>
>> Full log at:
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/73/builds/5569/steps/19/logs/stdio
>>
>>
>> --
>> Luca Ceresoli, Bootlin
>> Embedded Linux and Kernel engineering
>> https://bootlin.com
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#168820): https://lists.openembedded.org/g/openembedded-core/message/168820
>> Mute This Topic: https://lists.openembedded.org/mt/92768863/3616765
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [randy.macleod@windriver.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>

-- 
# Randy MacLeod
# Wind River Linux