Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Javier Tia <javier.tia@linaro.org>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] package: split strip cmd when ccache is used
Date: Tue, 31 Oct 2023 12:26:18 +0000	[thread overview]
Message-ID: <ba031885caf9dfeee099cbf4748a06f769c9de95.camel@linuxfoundation.org> (raw)
In-Reply-To: <20231031042735.3842176-1-javier.tia@linaro.org>

On Mon, 2023-10-30 at 22:27 -0600, Javier Tia wrote:
> Using ccache stopped to work after 77497dbdca with following error:
> 
>   FileNotFoundError: [Errno 2] No such file or directory: 'ccache aarch64-trs-linux-strip'
> 
> Signed-off-by: Javier Tia <javier.tia@linaro.org>
> ---
>  meta/lib/oe/package.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
> index 1dd20f85eb..2685da0af9 100644
> --- a/meta/lib/oe/package.py
> +++ b/meta/lib/oe/package.py
> @@ -39,7 +39,7 @@ def runstrip(arg):
>          newmode = origmode | stat.S_IWRITE | stat.S_IREAD
>          os.chmod(file, newmode)
>  
> -    stripcmd = [strip]
> +    stripcmd = strip.split() if "ccache" in strip else [strip]
>      skip_strip = False
>      # kernel module
>      if elftype & 16:

That looks very like a hack/workaround rather than a real fix. The
packaging code shouldn't know/care about ccache.

Should we always be splitting strip?

Cheers,

Richard




  reply	other threads:[~2023-10-31 12:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31  4:27 [PATCH] package: split strip cmd when ccache is used Javier Tia
2023-10-31 12:26 ` Richard Purdie [this message]
2023-10-31 15:29   ` [OE-core] " Christopher Larson
2023-11-20 15:28   ` Javier Tia
2023-11-20 16:06     ` Martin Jansa
2023-11-21 13:14       ` Javier Tia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba031885caf9dfeee099cbf4748a06f769c9de95.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=javier.tia@linaro.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox