Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 04/14] devtool: upgrade: drop superfluous call to validate_pn
Date: Wed, 24 Feb 2016 18:07:24 +1300	[thread overview]
Message-ID: <bb12032cc51a8564ca9abfe6ce7d34e826ad0fdb.1456290353.git.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <cover.1456290353.git.paul.eggleton@linux.intel.com>
In-Reply-To: <cover.1456290353.git.paul.eggleton@linux.intel.com>

The recipename argument to devtool upgrade specifies an existing recipe,
so by definition the name will be valid (or it won't exist) - we don't
need to validate it ourselves, that's only needed for situations like in
devtool add where we're creating a new recipe.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 scripts/lib/devtool/upgrade.py | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/scripts/lib/devtool/upgrade.py b/scripts/lib/devtool/upgrade.py
index a446c55..279a65f 100644
--- a/scripts/lib/devtool/upgrade.py
+++ b/scripts/lib/devtool/upgrade.py
@@ -297,12 +297,7 @@ def upgrade(args, config, basepath, workspace):
     if args.srcbranch and not args.srcrev:
         raise DevtoolError("If you specify --srcbranch/-B then you must use --srcrev/-S to specify the revision" % args.recipename)
 
-    reason = oe.recipeutils.validate_pn(args.recipename)
-    if reason:
-        raise DevtoolError(reason)
-
     tinfoil = setup_tinfoil(basepath=basepath, tracking=True)
-
     rd = parse_recipe(config, tinfoil, args.recipename, True)
     if not rd:
         return 1
-- 
2.5.0



  parent reply	other threads:[~2016-02-24  5:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24  5:07 [PATCH 00/14] devtool upgrade fixes Paul Eggleton
2016-02-24  5:07 ` [PATCH 01/14] devtool: add: tweak auto-determining name failure message Paul Eggleton
2016-02-24  5:07 ` [PATCH 02/14] devtool: modify: fix source tree default name when mapping virtuals Paul Eggleton
2016-02-24  5:07 ` [PATCH 03/14] devtool: upgrade: make source tree path optional Paul Eggleton
2016-02-24  5:07 ` Paul Eggleton [this message]
2016-02-24  5:07 ` [PATCH 05/14] devtool: upgrade: fix version argument checking Paul Eggleton
2016-02-24  5:07 ` [PATCH 06/14] devtool: upgrade: fix moving version-specific files directory Paul Eggleton
2016-02-24  5:07 ` [PATCH 07/14] devtool: upgrade: fix renaming of recipe if PV is not in name Paul Eggleton
2016-02-24  5:07 ` [PATCH 08/14] devtool: upgrade: fix constructing new branch from tarball releases Paul Eggleton
2016-02-24  5:07 ` [PATCH 09/14] devtool: upgrade: fix several issues with extraction of new source Paul Eggleton
2016-02-24  5:07 ` [PATCH 10/14] devtool: upgrade: eliminate unnecessary datastore copy Paul Eggleton
2016-02-24  5:07 ` [PATCH 11/14] devtool: upgrade: drop PR on upgrade Paul Eggleton
2016-02-24  5:07 ` [PATCH 12/14] devtool: upgrade: print new recipe name Paul Eggleton
2016-02-24  5:07 ` [PATCH 13/14] oe-selftest: devtool: rework devtool upgrade test Paul Eggleton
2016-02-24  5:07 ` [PATCH 14/14] oe-selftest: devtool: add an additional test for devtool upgrade Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb12032cc51a8564ca9abfe6ce7d34e826ad0fdb.1456290353.git.paul.eggleton@linux.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox