From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Alan Perry <alanp@snowmoose.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH v2 1/2] iproute2: install tools to mirror install under Debian/Ubuntu
Date: Mon, 07 Dec 2020 21:49:29 +0000 [thread overview]
Message-ID: <bb38bb9111dbc5e0a2c3c47256d2bead31b70316.camel@linuxfoundation.org> (raw)
In-Reply-To: <20201205082246.14954-1-alanp@snowmoose.com>
On Sat, 2020-12-05 at 08:22 +0000, Alan Perry wrote:
> Many scripts exist that expect the iproute2 tools to be found in
> the same directories where they are found in Debian or Ubuntu.
> For the iproute2 tools included in the iproute2 recipe, move
> them to those directories or create links there.. Also, add
> bash-completion files as is done by Debian and Ubuntu.
>
> Signed-off-by: Alan Perry <alanp@snowmoose.com>
> ---
> .../iproute2/iproute2.inc | 23 +++++++++++++++++--
> 1 file changed, 21 insertions(+), 2 deletions(-)
The direction in the patch is worrying me a little.
There is a bash-completion class which splits completion files into
their own package, most "embedded" users don't want them in the main
packages. This patch does something different to what has been done
elsewhere.
Secondly, I'm also not sure that just because debian does something we
should therefore do it, I'm not convinced that scripts should be
hardcoding path assumptions about these tools. IF this is such a
universal need, why doesn't upstream change the default installation
locations? Has it been discussed?
I'd expect there to be opinions on this topic but I'm not seeing much
discussion. I suspect if if does merge there would be push back later
though.
Also, the duplication between bin and sbin for ip is not particularly
good practise.
Cheers,
Richard
next prev parent reply other threads:[~2020-12-07 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 8:22 [PATCH v2 1/2] iproute2: install tools to mirror install under Debian/Ubuntu Alan Perry
2020-12-05 8:22 ` [PATCH v2 2/2] iproute2: rearrange FILES to improve readability Alan Perry
2020-12-07 21:49 ` Richard Purdie [this message]
2020-12-09 22:39 ` [OE-core] [PATCH v2 1/2] iproute2: install tools to mirror install under Debian/Ubuntu Alan Perry
2020-12-09 23:40 ` Andre McCurdy
2020-12-10 0:00 ` Alan Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb38bb9111dbc5e0a2c3c47256d2bead31b70316.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alanp@snowmoose.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox