public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Scott Branden" <scott.branden@broadcom.com>
To: OE-core <openembedded-core@lists.openembedded.org>,
	Nathan Rossi <nathan@nathanrossi.com>,
	Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: commit breaks menuconfig on upstream kernel "cml1.bbclass: Handle ncurses-native being available via pkg-config"
Date: Wed, 2 Dec 2020 11:17:41 -0800	[thread overview]
Message-ID: <bb945efa-f12d-6ff6-a783-8010269c9931@broadcom.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

Hi Nathan,

Your commit:
"cml1.bbclass: Handle ncurses-native being available via pkg-config"
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=master-next&id=ce447d70df386ca55ce1672478b245851556374e

breaks bitbake menuconfig when using the upstream kernel.

It only works with the linux-yocto kernel due to this workaround which is not upstream.
If you revert this commit in linux-yocto menuconfig will not work in linux-yocto:
"menuconfig,mconf-cfg: Allow specification of ncurses location"
https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit/scripts/kconfig/mconf-cfg.sh?h=v5.8/standard/base&id=1714a5ad9cf61f4d0f4b8432f327cca2998aba77


Seems like your commit needs to be reverted or a change made to work with the upstream kernel.
Or, the linux-yocto change needs to actually be upstreamed.  I submitted it and the upstream maintainer questioned why the change is needed:
https://lore.kernel.org/lkml/CAK7LNATD0J3C_mFrXAju8-WmdCmrPmRFn7Um0yebnfL-_zcu8w@mail.gmail.com/

Regards,
Scott






[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4169 bytes --]

             reply	other threads:[~2020-12-02 19:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 19:17 Scott Branden [this message]
2020-12-03  0:19 ` commit breaks menuconfig on upstream kernel "cml1.bbclass: Handle ncurses-native being available via pkg-config" Nathan Rossi
2020-12-03 11:17   ` [OE-core] " Andrey Zhizhikin
2020-12-03 18:13   ` Scott Branden
2020-12-03 18:18   ` Scott Branden
2020-12-03 22:31     ` [OE-core] " Andrey Zhizhikin
2020-12-04  0:53       ` Nathan Rossi
2020-12-04  4:58         ` Richard Purdie
2020-12-04  6:22           ` Nathan Rossi
2020-12-11 17:23             ` Scott Branden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb945efa-f12d-6ff6-a783-8010269c9931@broadcom.com \
    --to=scott.branden@broadcom.com \
    --cc=nathan@nathanrossi.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox