Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: JPEWhacker@gmail.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 0/2] Update to latest version of SPDX licenses
Date: Mon, 01 Jul 2024 07:56:50 +0100	[thread overview]
Message-ID: <bce5f93668412736c515e663d39c39696ccabf7b.camel@linuxfoundation.org> (raw)
In-Reply-To: <20240627221804.599573-1-JPEWhacker@gmail.com>

On Thu, 2024-06-27 at 16:16 -0600, Joshua Watt via lists.openembedded.org wrote:
> Adds a script to read the released SPDX license JSON data, and uses it
> to update the common license files
> 
> Joshua Watt (2):
>   scripts/pull-spdx-licenses.py: Add script
>   licenses: Update to SPDX license version 3.24.0

Thanks for doing this. It does seem to upset one of the selftests:

https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/6871

2024-06-30 21:07:48,909 - oe-selftest - INFO - ======================================================================
2024-06-30 21:07:48,966 - oe-selftest - INFO - FAIL: spdx.SPDXCheck.test_spdx_base_files (subunit.RemotedTestCase)
2024-06-30 21:07:48,966 - oe-selftest - INFO - ----------------------------------------------------------------------
2024-06-30 21:07:48,980 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/selftest/cases/spdx.py", line 55, in test_spdx_base_files
    self.check_recipe_spdx("packages", "base-files.spdx.json", "base-files")
  File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/selftest/cases/spdx.py", line 52, in check_recipe_spdx
    result = check_spdx_json(full_file_path)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/selftest/cases/spdx.py", line 49, in check_spdx_json
    result = runCmd("{} {} -i {}".format(python, validator, filename))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/utils/commands.py", line 212, in runCmd
    raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output))
AssertionError: Command '/home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-296488/tmp/work/x86_64-linux/python3-spdx-tools-native/0.8.2/recipe-sysroot-native/usr/bin/nativepython3 /home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-296488/tmp/work/x86_64-linux/python3-spdx-tools-native/0.8.2/recipe-sysroot-native/usr/bin/pyspdxtools -i /home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-296488/tmp/deploy/spdx/2.2/qemux86_64/packages/base-files.spdx.json' returned non-zero exit status 1:
ERROR:root:There have been issues while parsing the provided document:
Error while parsing Document: ['Error while parsing version 3.24.0: 3.24.0 is not a valid version string']

It is coming from here:

https://github.com/spdx/tools-python/blob/main/src/spdx_tools/spdx/model/version.py

in spdx-tools :/.

Cheers,

Richard


  parent reply	other threads:[~2024-07-01  6:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 22:16 [OE-core][PATCH 0/2] Update to latest version of SPDX licenses Joshua Watt
2024-06-27 22:16 ` [OE-core][PATCH 1/2] scripts/pull-spdx-licenses.py: Add script Joshua Watt
2024-06-27 22:16 ` [OE-core][PATCH 2/2] licenses: Update to SPDX license version 3.24.0 Joshua Watt
2024-07-01  6:56 ` Richard Purdie [this message]
2024-07-01 14:32   ` [OE-core][PATCH 0/2] Update to latest version of SPDX licenses Joshua Watt
2024-07-08  8:17     ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bce5f93668412736c515e663d39c39696ccabf7b.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=JPEWhacker@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox