Re: [PATCH 1/1] systemd: add back alternatives for init utitilies

[richard.purdie@linuxfoundation.org]

On Wed, 2018-10-24 at 14:16 +0800, ChenQi wrote:
> The failure is revealed by Kevin's patches regarding udev-extraconf. 
> More particularly, it's the following patch that reveals the problem.
> "udev-extraconf: Use the canonical file name of systemd"
> 
> I've sent out a patch to remove udev-extraconf from 
> packagegroup-core-lsb/-x11-sato to fix this failure.
> I tested 'testimage + core-image-sato/lsb' with the following 5
> patches 
> (3 from Kevin which are now on master-next, 2 from me) with master 
> branch, and the tests passed.
>   packagegroup-core-lsb/-x11-sato: no udev-extraconf in case of
> systemd
>   systemd: add back alternatives for init utitilies
>   udev-extraconf: Skip the entry in /etc/fstab when using the
> systemd-mount
>   udev-extraconf: Fix the recursively dependency for the systemd-
> mount
>   udev-extraconf: Use the canonical file name of systemd
> 
> P.S.
> I chose to remove udev-extraconf from these two packagegroups
> because:
> 1) udev-extraconf is needed in live image, so the automount rule
> needs 
> to be there in the final package, regardless of the init manager of
> the 
> real rootfs.
> 2) It's not clear whether users need the automount feature in case
> of 
> systemd. So I didn't choose to modify the mount.sh script to exit 
> directly if init manager is systemd.
> 3) I think it's not easy to make mount.sh reliable in systemd.
> Kevin's 
> patches are good and helpful, but still not solve all problems. e.g.
> The 
> mount.sh still doesn't take into consideration of .mount and
> .automount 
> units; and it does not consider this failure case, i.e. no medium
> found 
> on /dev/hdc.

Thanks for this, with travelling for ELC-E its been a week of
distractions so I appreciate someone looking into and figuring this
out!

Cheers,

Richard