Re: [OE-core] [PATCH] sanity.class: Add possibility to configure networking check

[Jacob Kroon <jacob.kroon@gmail.com>]

On 2/11/22 12:18, Ross Burton wrote:
> On Fri, 11 Feb 2022 at 08:44, Pavel Zhukov <pavel@zhukoff.net> wrote:
>> +        for uri in test_uris:
>> +            try:
>> +                if check_all:
>> +                    fetcher = bb.fetch2.Fetch(test_uris, data)
>> +                else:
>> +                    fetcher = bb.fetch2.Fetch([uri], data)
>> +                fetcher.checkstatus()
>> +                return retval
> 
> This seems like it's overcomplicating things to me.  example.com was
> having uptime issues, and we can change it to www.yoctoproject.org so
> that we know in advance of expected downtime, and have direct contact
> with the people responsible for keeping it up. So let's just change
> the URL to www.yoctoproject.org instead of adding more variables and
> non-trivial logic.
> 

I vote for removing the check altogether.

As I understand it, the check was added in order to prevent
hard-to-interpret error messages when network failed. I can live with that.

Jacob