Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: mariano.lopez@linux.intel.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] oeqa/utils/commands.py: Fix get_bb_vars() when called without arguments
Date: Wed, 14 Dec 2016 10:01:36 -0600	[thread overview]
Message-ID: <bed2fbbc-efb4-f04d-86cd-621a48e834f6@linux.intel.com> (raw)
In-Reply-To: <78c9c118e58c8b406baddaae656e791d7238f198.1481701176.git.mariano.lopez@linux.intel.com>



On 12/14/2016 01:45 AM, mariano.lopez@linux.intel.com wrote:
> From: Mariano Lopez <mariano.lopez@linux.intel.com>
>
> Commit 9d55e9d489cd78be592fb9b4d6484f9060c62fdd broke calling get_bb_vars()
> when called without arguments. This fix this issue.
>
> Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com>
> ---
>   meta/lib/oeqa/utils/commands.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/lib/oeqa/utils/commands.py b/meta/lib/oeqa/utils/commands.py
> index 6acb24a..aecf8cf 100644
> --- a/meta/lib/oeqa/utils/commands.py
> +++ b/meta/lib/oeqa/utils/commands.py
> @@ -149,7 +149,8 @@ def get_bb_vars(variables=None, target=None, postconfig=None):
>       """Get values of multiple bitbake variables"""
>       bbenv = get_bb_env(target, postconfig=postconfig)
>   
> -    variables = variables.copy()
> +    if variables is not None:
> +        variables = variables.copy()

Is 'variables' type is  a dict (or some derived type)? I see some 
get_bb_env calls using lists and lists do not have the copy method.

>       var_re = re.compile(r'^(export )?(?P<var>\w+)="(?P<value>.*)"$')
>       unset_re = re.compile(r'^unset (?P<var>\w+)$')
>       lastline = None



  reply	other threads:[~2016-12-14 15:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1481701176.git.mariano.lopez@linux.intel.com>
2016-12-14  7:45 ` [PATCH 1/1] oeqa/utils/commands.py: Fix get_bb_vars() when called without arguments mariano.lopez
2016-12-14 16:01   ` Leonardo Sandoval [this message]
2016-12-14 16:04     ` Lopez, Mariano
2016-12-14 16:13       ` Leonardo Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bed2fbbc-efb4-f04d-86cd-621a48e834f6@linux.intel.com \
    --to=leonardo.sandoval.gonzalez@linux.intel.com \
    --cc=mariano.lopez@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox