From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0110C4829B for ; Mon, 12 Feb 2024 12:17:58 +0000 (UTC) Received: from cpanel10.indieserve.net (cpanel10.indieserve.net [199.212.143.9]) by mx.groups.io with SMTP id smtpd.web11.5166.1707740273090861497 for ; Mon, 12 Feb 2024 04:17:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@crashcourse.ca header.s=default header.b=rEor2p0f; spf=pass (domain: crashcourse.ca, ip: 199.212.143.9, mailfrom: rpjday@crashcourse.ca) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crashcourse.ca; s=default; h=Content-Type:MIME-Version:References: Message-ID:In-Reply-To:Subject:cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sAnK12s8SStnfujmWU37ZJ31LvIaYkzfocBaMnk2SrQ=; b=rEor2p0flnEUi4HNBfrRhkWf+b w0Is16Zgr1jQj2TmvK0PS7bjFmsjJuhPUnNip/PBwYbGvY0+9vvaRKXqGs9780A7/k/kytbVjHQci LVs60gavmRacIh+qhVucJQ7EpL3UAHuIF5zs0IdWPc2PFOQc39yvN1afMyOfhPkhSEsbysaGHQZM5 hXmSVZ60UJPTWN1ALnvo6cYHBPU6TzIdHzcJqJA4BlTirUoqyNTVzXKDgXbd352F/P3gHJGVNLerA z0mdlRFb/Xx5VNS5Xs1Un8fXd9NAfc9KT8Tx/8rPdGIuTuXCZgSwvCJCfCew0aSTmuMN2MMWMcGwl 3xIaHW9w==; Received: from cpeac202e043973-cmac202e043970.sdns.net.rogers.com ([174.114.102.5]:41488 helo=fedora) by cpanel10.indieserve.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rZVFs-00Bzbe-2M; Mon, 12 Feb 2024 07:17:51 -0500 Date: Mon, 12 Feb 2024 07:17:42 -0500 (EST) From: "Robert P. J. Day" To: Ross Burton cc: OE Core mailing list Subject: Re: [OE-core] more ptest pedantry: why conditionally include "run-ptest" in SRC_URI? In-Reply-To: <8C7A9199-D49B-4190-9D96-F060CD858C71@arm.com> Message-ID: References: <8d71c0f-9120-85b7-80ce-d985aa557f8@crashcourse.ca> <8C7A9199-D49B-4190-9D96-F060CD858C71@arm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323328-196217760-1707740269=:389998" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel10.indieserve.net X-AntiAbuse: Original Domain - lists.openembedded.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Get-Message-Sender-Via: cpanel10.indieserve.net: authenticated_id: rpjday+crashcourse.ca/only user confirmed/virtual account not confirmed X-Authenticated-Sender: cpanel10.indieserve.net: rpjday@crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 12 Feb 2024 12:17:58 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/195314 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-196217760-1707740269=:389998 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Mon, 12 Feb 2024, Ross Burton wrote: > On 12 Feb 2024, at 06:39, Robert P. J. Day via lists.openembedded.org wrote: > > more annoying nitpickery ... here: > > > > https://git.openembedded.org/openembedded-core/tree/meta/recipes-extended/xz/xz_5.4.5.bb#n28 > > > > it's not clear why someone would go to the trouble of conditionally > > including run-ptest in SRC_URI as i would have thought the only > > benefit would be to avoid the triviality of copying run-ptest into > > WORKDIR, but beyond that, i don't see what the point is, and that's > > the only recipe i've run across that bothers to do that. > > > > is there something more subtle happening here? > > No good reason, and I’d approve a patch that removed the > conditionals on the grounds of cleaning up the recipe and ensuring > that there’s less conditional paths through the recipe. it gets even stranger when you have a conditional to apply a test patch, like here: https://git.openembedded.org/meta-openembedded/tree/meta-networking/recipes-protocols/freediameter/freediameter_1.4.0.bb#n21 i am also assuming that it's cleaner to conditionally check for ptest assignment for stuff like SRC_URI and DEPENDS, not with: ${@bb.utils.contains('DISTRO_FEATURES', 'ptest' ... but with the more intuitive: ${@bb.utils.contains('PTEST_ENABLED', '1', ... rday --8323328-196217760-1707740269=:389998--