Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] kern-devsrc: Drop auto.conf creation
Date: Tue, 09 Aug 2022 14:26:16 +0100	[thread overview]
Message-ID: <bfc1c1a5b9ac8093b409129b825c41696650f66a.camel@linuxfoundation.org> (raw)
In-Reply-To: <CADkTA4MBRL7JuLA8D32K1_CcyDMcRO=hfJyghPHyUZtwKw-nqA@mail.gmail.com>

On Tue, 2022-08-09 at 09:16 -0400, Bruce Ashfield wrote:
> On Tue, Aug 9, 2022 at 7:14 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > After this commit in the mainline kernel, the quoting is different in auto.conf
> > compared to .config:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=129ab0d2d9f38b9d43df35235fc66c6740d6928b
> > 
> > We therefore can't just copy one over the other or it leads to syntax/quoting
> > errors. We end up running make prepare anyway in all our tests so drop
> > this copy for fix 5.19 kernels.
> 
> It is safe to stop doing this manipulation now.
> 
> But I am curious, I was running on-target tests for 5.19+ and didn't
> have any issues, what is breaking that I managed to miss ?

https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/5629/steps/13/logs/stdio

Basically any kernelmodule.KernelModuleTest.test_kernel_module which
was run was failing (which would run on any image with kernel-devsrc in
and a toolchain). It failed everywhere, all sdk qemu machines equally.

> There is a risk that if the .cmd files start regenerating because of
> this missing, or the different timestamp, that we'll have issues. But
> putting it through the AB should show us if that is true.

After this change is applied, the build looks a lot greener and this
issue goes away.

Cheers,

Richard


  reply	other threads:[~2022-08-09 13:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 11:14 [PATCH] kern-devsrc: Drop auto.conf creation Richard Purdie
2022-08-09 13:16 ` Bruce Ashfield
2022-08-09 13:26   ` Richard Purdie [this message]
2022-08-09 13:29     ` Bruce Ashfield
2022-08-09 14:08       ` Richard Purdie
2022-08-09 14:22         ` Bruce Ashfield
2022-08-09 14:26           ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfc1c1a5b9ac8093b409129b825c41696650f66a.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bruce.ashfield@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox