From: Khem Raj <raj.khem@gmail.com>
To: "Mittal, Anuj" <anuj.mittal@intel.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON
Date: Tue, 18 Feb 2020 18:55:10 -0800 [thread overview]
Message-ID: <c03634be-a243-4975-97fc-0211313ab32a@gmail.com> (raw)
In-Reply-To: <bc67d00aa872e879748e6b05fe3a104304194c07.camel@intel.com>
On 2/18/20 6:43 PM, Mittal, Anuj wrote:
> On Tue, 2020-02-18 at 18:39 -0800, Khem Raj wrote:
>> On Tue, Feb 18, 2020 at 6:37 PM Anuj Mittal <anuj.mittal@intel.com>
>> wrote:
>>> Use the correct variable so options actually get used and use the
>>> correct qt option name to prevent errors.
>>>
>>> Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
>>> ---
>>> .../gstreamer/gstreamer1.0-plugins-good_1.16.1.bb | 4
>>> ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-
>>> plugins-good_1.16.1.bb b/meta/recipes-
>>> multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb
>>> index a6eb9986dd..07a0bf5085 100644
>>> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-
>>> good_1.16.1.bb
>>> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-
>>> good_1.16.1.bb
>>> @@ -55,7 +55,7 @@ PACKAGECONFIG[x11] =
>>> "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}"
>>> # This is better done in a separate qt5 layer (which then should
>>> add a "qt5" packageconfig
>>> # in a gstreamer1.0-plugins-good bbappend).
>>>
>>> -EXTRA_OECONF += " \
>>> +EXTRA_OEMESON += " \
>>> -Daalib=disabled \
>>> -Ddirectsound=disabled \
>>> -Ddv=disabled \
>>> @@ -64,7 +64,7 @@ EXTRA_OECONF += " \
>>> -Doss4=disabled \
>>> -Dosxaudio=disabled \
>>> -Dosxvideo=disabled \
>>> - -Dqt=disabled \
>>> + -Dqt5=disabled \
>> this perhaps should be a packageconfig so people using meta-qt5 can
>> enable it
> Yes probably but in a separate change I think. This just ensures that
> the right options are used and nothing else is changed.
perhaps no, since it will regress meta-qt5 which already does something
like this
https://github.com/meta-qt5/meta-qt5/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_%25.bbappend
this being wrong in OE-core was ok for meta-qt5.
>
> Thanks,
>
> Anuj
>
>>> -Dshout2=disabled \
>>> -Dtwolame=disabled \
>>> -Dwaveform=disabled \
>>> --
>>> 2.24.1
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2020-02-19 2:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 2:36 [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON Anuj Mittal
2020-02-19 2:39 ` Khem Raj
2020-02-19 2:43 ` Mittal, Anuj
2020-02-19 2:55 ` Khem Raj [this message]
2020-02-19 3:04 ` Mittal, Anuj
2020-02-19 3:35 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c03634be-a243-4975-97fc-0211313ab32a@gmail.com \
--to=raj.khem@gmail.com \
--cc=anuj.mittal@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox