From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Dan McGregor <danismostlikely@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] python3: fix multilib in distutils
Date: Thu, 30 Nov 2017 21:29:06 +0200 [thread overview]
Message-ID: <c0bf2792-4c65-991a-3cb8-a4960515d784@linux.intel.com> (raw)
In-Reply-To: <20171130162857.24082-1-danismostlikely@gmail.com>
On 11/30/2017 06:28 PM, Dan McGregor wrote:
> From: Dan McGregor <dan.mcgregor@usask.ca>
>
> Update the multilib patch to also use sys.lib in distutils.
>
> Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca>
This patch makes two different recipe patches modify the same line
twice. Can you squash that into a single change so that it's clear what
is being changed, and what is the final state. Also, please do provide
an explanation in the commit message: why the original code is
incorrect, and why the new one is correct.
Alex
prev parent reply other threads:[~2017-11-30 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 16:28 [PATCH] python3: fix multilib in distutils Dan McGregor
2017-11-30 19:29 ` Alexander Kanavin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0bf2792-4c65-991a-3cb8-a4960515d784@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=danismostlikely@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox