From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mikko Rapeli <mikko.rapeli@linaro.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] oeqa/selftest/runtime_test: No need to use append with TEST_RUNQEMUPARAMS
Date: Tue, 12 Sep 2023 12:50:26 +0100 [thread overview]
Message-ID: <c33d61dd74726e6f11b2ad78f43f1d0d439b6615.camel@linuxfoundation.org> (raw)
In-Reply-To: <ZQBPnpWNx3iyWfnV@nuoska>
On Tue, 2023-09-12 at 14:46 +0300, Mikko Rapeli wrote:
> Hi,
>
> On Tue, Sep 12, 2023 at 12:32:42PM +0100, Richard Purdie wrote:
> > A simple += operation is fine for working with TEST_RUNQEMUPARAMS so remove
> > the heavier append override usage.
>
> Ok, but I was being consistent with the other variables in the tests.
Fair enough, I did kind of guess that. In general we want to try and
reduce the amount of :append use over time though so where we have a
choice, we should just use +=.
Cheers,
Richard
next prev parent reply other threads:[~2023-09-12 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 11:32 [PATCH] oeqa/selftest/runtime_test: No need to use append with TEST_RUNQEMUPARAMS Richard Purdie
2023-09-12 11:46 ` [OE-core] " Mikko Rapeli
2023-09-12 11:50 ` Richard Purdie [this message]
2023-09-12 11:54 ` Mikko Rapeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c33d61dd74726e6f11b2ad78f43f1d0d439b6615.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=mikko.rapeli@linaro.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox