Re: [V2][PATCH] gnutls: Update to 3.6.3

From: akuster808 <akuster808@gmail.com>
To: Andre McCurdy <armccurdy@gmail.com>, Armin Kuster <akuster808@gmail.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [V2][PATCH] gnutls: Update to 3.6.3
Date: Fri, 17 Aug 2018 15:39:30 -0700	[thread overview]
Message-ID: <c658c3fa-b055-ba33-af4e-e5f599fe53e4@gmail.com> (raw)
In-Reply-To: <CAJ86T=WfkmRWbrj6EgQXyRNhYxTxhzEfNvCkLySa3q1=hNmK_Q@mail.gmail.com>

On 08/17/2018 02:31 PM, Andre McCurdy wrote:
> On Fri, Aug 17, 2018 at 7:14 AM, Armin Kuster <akuster808@gmail.com> wrote:
>> [v2]
>> Fix new config options form with to disable.
>>
>> [v1]
>> release notes: https://lists.gnupg.org/pipermail/gnutls-devel/2018-July/008584.html
>>
>> add ssl3 and tls1.3 config options now supported.
>>
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>>  meta/recipes-support/gnutls/gnutls.inc                       | 2 ++
>>  .../gnutls/{gnutls_3.6.2.bb => gnutls_3.6.3.bb}              | 5 +++--
>>  2 files changed, 5 insertions(+), 2 deletions(-)
>>  rename meta/recipes-support/gnutls/{gnutls_3.6.2.bb => gnutls_3.6.3.bb} (53%)
>>
>> diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
>> index 04c0fd2af8..f204e5f4c0 100644
>> --- a/meta/recipes-support/gnutls/gnutls.inc
>> +++ b/meta/recipes-support/gnutls/gnutls.inc
>> @@ -30,6 +30,8 @@ PACKAGECONFIG[libidn] = "--with-idn,--without-idn,libidn2"
>>  PACKAGECONFIG[libtasn1] = "--with-included-libtasn1=no,--with-included-libtasn1,libtasn1"
>>  PACKAGECONFIG[p11-kit] = "--with-p11-kit,--without-p11-kit,p11-kit"
>>  PACKAGECONFIG[tpm] = "--with-tpm,--without-tpm,trousers"
>> +PACKAGECONFIG[ssl3] = "--enable-ssl3-support,--disable-ssl3-support,"
>> +PACKAGECONFIG[tls13] = "--enable-tls13-support,--disable-tls13-support,"
> I'm not sure whether either of these should have PACKAGECONFIG options.
>
> SSL v3 is obsolete and if gnutls is disabling it by default now then
> it's probably best to leave it that way (dead and buried). Experienced
> users can always enable via EXTRA_OECONF if they really need it.
>
> TLS 1.3 is the opposite - it's brand new. If we add a PACKAGECONFIG
> option to control it then it becomes the gnutls recipe maintainer's
> job to figure out when to enable it by default. I think it's better to
> leave that decision to upstream gnutls.
No change in behavior in the way its setup now.

You can send a patch to correct them. I am not doing a v3 for this.

- armin
>
>>  EXTRA_OECONF = " \
>>      --enable-doc \
>> diff --git a/meta/recipes-support/gnutls/gnutls_3.6.2.bb b/meta/recipes-support/gnutls/gnutls_3.6.3.bb
>> similarity index 53%
>> rename from meta/recipes-support/gnutls/gnutls_3.6.2.bb
>> rename to meta/recipes-support/gnutls/gnutls_3.6.3.bb
>> index e540528a8e..c560305032 100644
>> --- a/meta/recipes-support/gnutls/gnutls_3.6.2.bb
>> +++ b/meta/recipes-support/gnutls/gnutls_3.6.3.bb
>> @@ -3,7 +3,8 @@ require gnutls.inc
>>  SRC_URI += "file://0001-configure.ac-fix-sed-command.patch \
>>              file://arm_eabi.patch \
>>             "
>> -SRC_URI[md5sum] = "8b4912c6c0e5ffefd3dbb4888eaf8a58"
>> -SRC_URI[sha256sum] = "bcd5db7b234e02267f36b5d13cf5214baac232b7056a506252b7574ea7738d1f"
>> +
>> +SRC_URI[md5sum] = "d3b1b05c2546b80832101a423a80faf8"
>> +SRC_URI[sha256sum] = "ed642b66a4ecf4851ab2d809cd1475c297b6201d8e8bd14b4d1c08b53ffca993"
>>
>>  BBCLASSEXTEND = "native nativesdk"
>> --
>> 2.17.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core