public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Steve Sakoman" <steve@sakoman.com>
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][dunfell 5/7] sysvinit: Remove ${B} assignment
Date: Fri, 18 Sep 2020 06:15:13 -1000	[thread overview]
Message-ID: <c8ad554db100b9fd16097fc8616b2af5390772e7.1600445624.git.steve@sakoman.com> (raw)
In-Reply-To: <cover.1600445624.git.steve@sakoman.com>

From: Michael Gloff <mgloff@emacinc.com>

The VERSION variable is not set unless the
top level Makefile is used as the version is
derived from the Changelog.
If VERSION is not set, none of the binaries built
in the sysvinit recipe will have a valid version
output.
Before:
INIT: version  booting
After:
INIT: version 2.96 booting

Using the top level Makefile does not cause any
additional builds to occur.

Signed-off-by: Michael Gloff <mgloff@emacinc.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 10992ad4f343d0f92d9d6246cc2e58effd3f3eeb)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/recipes-core/sysvinit/sysvinit_2.96.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-core/sysvinit/sysvinit_2.96.bb b/meta/recipes-core/sysvinit/sysvinit_2.96.bb
index d2b85ed9c0..7358f02385 100644
--- a/meta/recipes-core/sysvinit/sysvinit_2.96.bb
+++ b/meta/recipes-core/sysvinit/sysvinit_2.96.bb
@@ -25,7 +25,6 @@ SRC_URI[md5sum] = "48cebffebf2a96ab09bec14bf9976016"
 SRC_URI[sha256sum] = "2a2e26b72aa235a23ab1c8471005f890309ce1196c83fbc9413c57b9ab62b587"
 
 S = "${WORKDIR}/sysvinit-${PV}"
-B = "${S}/src"
 
 inherit update-alternatives features_check
 DEPENDS_append = " update-rc.d-native base-passwd virtual/crypt"
-- 
2.17.1


  parent reply	other threads:[~2020-09-18 16:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 16:15 [OE-core][dunfell 0/7] Patch review Steve Sakoman
2020-09-18 16:15 ` [OE-core][dunfell 1/7] systemd-serialgetty: Fix sed expression quoting Steve Sakoman
2020-09-18 16:15 ` [OE-core][dunfell 2/7] systemd-serialgetty: Replace sed quoting using ' with " to allow var expansion Steve Sakoman
2020-09-18 16:15 ` [OE-core][dunfell 3/7] initramfs-framework: support kernel cmdline with double quotes Steve Sakoman
2020-09-18 16:15 ` [OE-core][dunfell 4/7] libubootenv: upgrade 0.3 -> 0.3.1 Steve Sakoman
2020-09-18 16:15 ` Steve Sakoman [this message]
2020-09-18 16:15 ` [OE-core][dunfell 6/7] populate_sdk_ext: Do not assume local.conf will always exist Steve Sakoman
2020-09-18 16:15 ` [OE-core][dunfell 7/7] Revert "kernel.bbclass: run do_symlink_kernsrc before do_patch" Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8ad554db100b9fd16097fc8616b2af5390772e7.1600445624.git.steve@sakoman.com \
    --to=steve@sakoman.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox