Re: [OE-core] [PATCH v4] systemd: update to v254

Khem Raj
2023-08-02T17:42:57Z

On Wed, Aug 2, 2023 at 10:21 AM Luca Boccassi <luca.boccassi@gmail.com> wrote:
>
> On Wed, 2 Aug 2023 at 18:14, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > Luca
> >
> > On Wed, Aug 2, 2023 at 1:12 AM Luca Bocassi <luca.boccassi@gmail.com> wrote:
> > >
> > > On Mon, 31 Jul 2023 at 19:00, Luca Boccassi <luca.boccassi@gmail.com> wrote:
> > > >
> > > > On Mon, 31 Jul 2023 at 18:37, Alexander Kanavin <alex.kanavin@gmail.com> wrote:
> > > > >
> > > > > A better option: fix the libpam recipe to say:
> > > > >
> > > > > ANY_OF_DISTRO_FEATURES = "pam systemd"
> > > > > instead of current
> > > > > REQUIRED_DISTRO_FEATURES = "pam"
> > > > >
> > > > >
> > > > > This should avoid having to fix the tests.
> > > >
> > > > Thanks for the suggestion, applied in v6.
> > >
> > > Hi, did v6 help with those test runs? Thanks
> >
> >
> > I am seeing a build failure with TCLIBC=musl
> >
> > | ../git/src/basic/user-util.c:708:30: error: use of undeclared
> > identifier 'LOCK_EX'; did you mean 'LOCK_BSD'?
> > | 708 | r = unposix_lock(fd, LOCK_EX);
> > | | ^~~~~~~
> > | | LOCK_BSD
> > | ../git/src/basic/lock-util.h:38:9: note: 'LOCK_BSD' declared here
> > | 38 | LOCK_BSD,
> > | | ^
> > | 1 error generated.
>
> Yes, as mentioned on the patch note itself, I only rebased the musl
> patches so that they apply (and dropped the merged ones), but I have
> not (and will not) test them in any other way, as I do not use musl.

OK np.
I have sent a pull upsrtream - https://github.com/systemd/systemd/pull/28647

there is another issue where systemd has started using glibc-only
malloc_trim API [1]
so we need another patch to mark it accordingly. I will see what we can do there

[1] https://github.com/systemd/systemd/commit/158fe190afe37b222c9dc2c53bd7be426b92ef89

>
> Kind regards,
> Luca Boccassi