Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: kai.kang@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 03/10] man-db: fix multilib install file conflict
Date: Sat, 29 Sep 2018 13:44:48 +0100	[thread overview]
Message-ID: <ca4435b5ac4b9deecf9a3fd2eb9c89b86f435056.camel@linuxfoundation.org> (raw)
In-Reply-To: <e264c183d7ab6ce4087ac6fca6bd6cadff6026c4.1538199671.git.kai.kang@windriver.com>

On Sat, 2018-09-29 at 13:43 +0800, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
> 
> The first line of config file man_db.conf is the package name. It
> causes
> multilib install file conflict. So remove the first line.
> 
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/recipes-extended/man-db/man-db_2.8.3.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-extended/man-db/man-db_2.8.3.bb
> b/meta/recipes-extended/man-db/man-db_2.8.3.bb
> index 97e5a3d6fb..da6d291011 100644
> --- a/meta/recipes-extended/man-db/man-db_2.8.3.bb
> +++ b/meta/recipes-extended/man-db/man-db_2.8.3.bb
> @@ -26,6 +26,9 @@ do_install() {
>  	        install -d ${D}/etc/default/volatiles
>  		install -m 0644 ${WORKDIR}/99_mandb
> ${D}/etc/default/volatiles
>  	fi
> +
> +    # the 1st line of man_db.conf is package name which causes
> multilib install file conflict
> +    sed -i '1d' ${D}${sysconfdir}/man_db.conf
>  }

Please do this with a patch, not a sed expression.

The sed expressions are a maintenance nightmare since we don't know
if/when the config file may change, or if/when this expression stops
working.

Cheers,

Richard



  reply	other threads:[~2018-09-29 12:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-29  5:43 [PATCH v2 00/10] Fix multilib install conflicts kai.kang
2018-09-29  5:43 ` [PATCH 01/10] cups: fix multilib install file conflicts kai.kang
2018-09-29  5:43 ` [PATCH 02/10] bind: " kai.kang
2018-09-29  5:43 ` [PATCH 03/10] man-db: fix multilib install file conflict kai.kang
2018-09-29 12:44   ` Richard Purdie [this message]
2018-09-30  1:02     ` Kang Kai
2018-09-29  5:43 ` [PATCH 04/10] groff: fix multilib install file conflicts kai.kang
2018-09-29  5:43 ` [PATCH 05/10] nss: move create blank certificates to pkg_postinst kai.kang
2018-09-29 12:44   ` Richard Purdie
2018-10-02 15:29     ` Kang Kai
2018-10-02 15:53       ` richard.purdie
2018-10-02 16:33         ` Kang Kai
2018-10-11  7:55         ` Kang Kai
2018-09-29  5:43 ` [PATCH 06/10] libcheck: avoid multilib install file conflict kai.kang
2018-09-29 12:42   ` Richard Purdie
2018-09-30  1:03     ` Kang Kai
2018-09-29  5:43 ` [PATCH 07/10] opkg-utils/update-alternatives: not warn same priorities for multilib kai.kang
2018-09-29 12:40   ` Richard Purdie
2018-09-29  5:43 ` [PATCH 08/10] os-release: fix install file conflict " kai.kang
2018-09-29 12:37   ` Richard Purdie
2018-09-30  1:07     ` Kang Kai
2018-09-29  5:43 ` [PATCH 09/10] gobject-introspection: fix multilib install file conflicts kai.kang
2018-09-29  5:43 ` [PATCH 10/10] vala: update vapigen-wrapper kai.kang
2018-09-29 12:33   ` Richard Purdie
2018-09-30  1:26     ` Kang Kai
  -- strict thread matches above, loose matches on Subject: below --
2018-09-29  5:01 [PATCH 00/10] Fix multilib install conflicts kai.kang
2018-09-29  5:01 ` [PATCH 03/10] man-db: fix multilib install file conflict kai.kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca4435b5ac4b9deecf9a3fd2eb9c89b86f435056.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=kai.kang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox