From: "Anuj Mittal" <anuj.mittal@intel.com>
To: Minjae Kim <flowergom@gmail.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [dunfell][PATCH] rpm: fix CVE-2021-3421
Date: Fri, 25 Jun 2021 01:29:23 +0000 [thread overview]
Message-ID: <cc3503555b1342edbb4ec76dc7595fcf@intel.com> (raw)
In-Reply-To: <20210624132904.873-1-flowergom@gmail.com>
> + /* Bump reference count for return. */ diff --git a/lib/rpmtag.h
> +b/lib/rpmtag.h index 8c718b31b5..d562572c6f 100644
> +--- a/lib/rpmtag.h
> ++++ b/lib/rpmtag.h
> +@@ -65,6 +65,8 @@ typedef enum rpmTag_e {
> + RPMTAG_LONGARCHIVESIZE = RPMTAG_SIG_BASE+15, /* l */
> + /* RPMTAG_SIG_BASE+16 reserved */
> + RPMTAG_SHA256HEADER = RPMTAG_SIG_BASE+17, /* s */
> ++ /* RPMTAG_SIG_BASE+18 reserved for RPMSIGTAG_FILESIGNATURES */
> ++ /* RPMTAG_SIG_BASE+19 reserved for
> RPMSIGTAG_FILESIGNATURELENGTH
> ++ */
> +
> + RPMTAG_NAME = 1000, /* s */
> + #define RPMTAG_N RPMTAG_NAME /* s */
> +@@ -422,6 +424,8 @@ typedef enum rpmSigTag_e {
> + RPMSIGTAG_LONGSIZE = RPMTAG_LONGSIGSIZE, /*!< internal
> Header+Payload size (64bit) in bytes. */
> + RPMSIGTAG_LONGARCHIVESIZE = RPMTAG_LONGARCHIVESIZE, /*!<
> internal uncompressed payload size (64bit) in bytes. */
> + RPMSIGTAG_SHA256 = RPMTAG_SHA256HEADER,
> ++ RPMSIGTAG_FILESIGNATURES = RPMTAG_SIG_BASE + 18,
> ++ RPMSIGTAG_FILESIGNATURELENGTH = RPMTAG_SIG_BASE + 19,
> + } rpmSigTag;
> +
Was this hunk added to make the backported patch compile? Considering 4.14.x version doesn't use RPMSIGTAG_FILESIGNATURES at all, I am wondering if this change works as intended?
Thanks,
Anuj
next prev parent reply other threads:[~2021-06-25 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 13:29 [dunfell][PATCH] rpm: fix CVE-2021-3421 Minjae Kim
2021-06-25 1:29 ` Anuj Mittal [this message]
2021-06-25 5:30 ` Minjae Kim
2021-06-25 15:07 ` [OE-core] " Steve Sakoman
2021-06-26 5:55 ` Minjae Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc3503555b1342edbb4ec76dc7595fcf@intel.com \
--to=anuj.mittal@intel.com \
--cc=flowergom@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox