Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: ejo@pengutronix.de, openembedded-core@lists.openembedded.org
Cc: yocto@pengutronix.de, "Ulrich Ölmann" <u.oelmann@pengutronix.de>
Subject: Re: [OE-core] [PATCH] barebox.bbclass: use consistent make flags for menuconfig
Date: Thu, 27 Feb 2025 11:17:06 +0000	[thread overview]
Message-ID: <ce6258c66b0a7c5eeeb8cbcc6a38b5d39a8b3bd5.camel@linuxfoundation.org> (raw)
In-Reply-To: <20250227092821.2766396-1-ejo@pengutronix.de>

On Thu, 2025-02-27 at 10:28 +0100, Enrico Jörns via lists.openembedded.org wrote:
> This change is done similar to the change in the kernel.bbclass of
> commit 8c616bc0 ("kernel: Use consistent make flags for menuconfig").
> 
> This was discovered since the new CONFIG_GCC_VERSION kconfig symbol
> reflected the host GCC version instead of the target ones after running
> do_menuconfig.
> 
> Reported-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
> ---
>  meta/classes-recipe/barebox.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes-recipe/barebox.bbclass b/meta/classes-recipe/barebox.bbclass
> index 200ba08326..baba0a2965 100644
> --- a/meta/classes-recipe/barebox.bbclass
> +++ b/meta/classes-recipe/barebox.bbclass
> @@ -53,6 +53,7 @@ EXTRA_OEMAKE = " \
>      PKG_CONFIG=pkg-config-native \
>      CROSS_PKG_CONFIG=pkg-config \
>  "
> +KCONFIG_CONFIG_COMMAND:append = " ${EXTRA_OEMAKE}"
>  

Can we use += here rather than append?

Cheers,

Richard


  reply	other threads:[~2025-02-27 11:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27  9:28 [PATCH] barebox.bbclass: use consistent make flags for menuconfig Enrico Jörns
2025-02-27 11:17 ` Richard Purdie [this message]
2025-02-27 11:23   ` [OE-core] " Enrico Jörns
2025-02-27 11:44     ` Richard Purdie
2025-02-27 11:47       ` Enrico Jörns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce6258c66b0a7c5eeeb8cbcc6a38b5d39a8b3bd5.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=ejo@pengutronix.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=u.oelmann@pengutronix.de \
    --cc=yocto@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox