Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH 0/4] Ensure a reasonable umask, and fix up permissions
Date: Wed, 22 Jun 2011 18:23:23 -0500	[thread overview]
Message-ID: <cover.1308784531.git.mark.hatle@windriver.com> (raw)

A fairly global problem was discovered that depending on the build users
umask, the directories and files being generated ended up with different
permissions.  This lead to situations where the first package to be
installed setup the permissions and could have lead to bugs and security
issues.

This patch set resolves the problem in two ways.  First it sets the umask
to a sane value for distribution creation, 022.  Note: I intentionally left
the patches and reverted global umask in this patch set.  Without the 
corresponding changes to bitbake the "Add umask task control" won't do
anything.

The package.bbclass change is described within that specific commit.  Note
there is still one outstanding issue when one package uses a directory and
another defines the item in terms of a symlink.  I intend to enhance the
code to deal with that situation in a future commit.

The following changes since commit f40f936b3ba00e31cae49c22b2633d4deb825533:

  Revert "eglibc: Upgrade recipes from 2.13 -> 2.14" (2011-06-22 16:52:11 -0500)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib mhatle/perms
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/perms

Mark Hatle (4):
  classes/base.bbclass: Add umask
  Revert "classes/base.bbclass: Add umask"
  Add umask task control
  classes/package.bbclass: Add fixup_perms

 meta/classes/base.bbclass                          |    4 +
 meta/classes/image.bbclass                         |    2 +
 meta/classes/package.bbclass                       |  168 ++++++++++++++++++--
 meta/classes/staging.bbclass                       |    1 +
 meta/files/fs-perms.txt                            |   39 +++++
 .../installer/adt-installer_1.0.bb                 |    2 +
 meta/recipes-kernel/linux/linux-tools.inc          |    2 +
 7 files changed, 208 insertions(+), 10 deletions(-)
 create mode 100644 meta/files/fs-perms.txt

-- 
1.7.3.4




             reply	other threads:[~2011-06-22 23:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22 23:23 Mark Hatle [this message]
2011-06-22 23:23 ` [PATCH 1/4] classes/base.bbclass: Add umask Mark Hatle
2011-06-22 23:23 ` [PATCH 2/4] Revert "classes/base.bbclass: Add umask" Mark Hatle
2011-06-22 23:23 ` [PATCH 3/4] Add umask task control Mark Hatle
2011-06-22 23:23 ` [PATCH 4/4] classes/package.bbclass: Add fixup_perms Mark Hatle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1308784531.git.mark.hatle@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox