Re: [PATCH 1/1] busybox: add config fragments

Bruce Ashfield
2013-02-13T17:15:35Z

On Wed, Feb 13, 2013 at 11:53 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Tue, 2013-02-12 at 11:50 -0500, Bruce Ashfield wrote:
>> Attached is the fixed up patch with DEPENDS, the existing one had a typo
>> in:
>>
>> do_config[depends] = "kern-tools-native:do_populate_sysroot"
>>
>> I've gone ahead and replaced it with a DEPENDS and tested the failure case
>> here.
>>
>> This is a complete patch replacement, let me know if you'd prefer something
>> incremental.
>
> DEPENDS should be towards the start of the file and/or use =+ in case
> something in one of the classes also sets DEPENDS. I tweaked and merged
> it since I don't really want to review it again ;-).

Sounds good, thanks for the += addition, as for the location, I just
put it right
over the spot of the old dependency, since it wasn't going out of my way to
clean parts not related to the immediate fix :)

Cheers,

Bruce

>
> Cheers,
>
> Richard
>

--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"