From: Peter Seebach <peter.seebach@windriver.com>
To: OE-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH 0/1] pseudo: honor umask again
Date: Tue, 27 May 2014 14:35:25 -0500 [thread overview]
Message-ID: <cover.1401219091.git.peter.seebach@windriver.com> (raw)
The fchmodat patch subtly broke umask support. The key here is that
since I was thinking about chmod, chmod is what I tested, and chmod
ignores umask. But the patch had the side effect of masking in 022
bits if they were set in the requested mode for an open/mkdir/mknod,
even if umask would have removed them from the filesystem.
This patch corrects that, and also in passing removes a completely
spurious double-mask-out of extra bits. It turns out that
((x) & ~y)
is just as good as
(((x) & ~y) & ~y)
The patch looks larger than it really is, just because diffs-of-diffs;
the substance is that each of the mknod/mkdir/open functions which
actually works with the mode flag now masks out pseudo_umask, which
is set during the initial pseudo client setup, and updated whenever
umask is called.
Many thanks to kroon in #yocto for bringing this to my attention.
The following changes since commit 9948e4239b88026804c33d84830dbfe6b0ed3e59:
eglinfo: updated to compile with mesa10+ (2014-05-27 16:10:25 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib seebs/umask
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/umask
Peter Seebach (1):
pseudo: Honor umask again
.../pseudo/files/pseudo-fchmodat-permissions.patch | 163 +++++++++++++++++++-
1 files changed, 157 insertions(+), 6 deletions(-)
next reply other threads:[~2014-05-27 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 19:35 Peter Seebach [this message]
2014-05-27 19:35 ` [PATCH 1/1] pseudo: Honor umask again Peter Seebach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1401219091.git.peter.seebach@windriver.com \
--to=peter.seebach@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox