Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Peter Seebach <peter.seebach@windriver.com>
To: OE-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH 0/1] pseudo fchmodat, this time for sure
Date: Tue, 27 May 2014 19:14:45 -0500	[thread overview]
Message-ID: <cover.1401235888.git.peter.seebach@windriver.com> (raw)

This improves on the previous patch by moving the umask clearing
in mkdirat() outside of a rarely-used #ifdef block.

It improves on the original submission by masking out umasks at all,
which turns out to be necessary for mkdir, open, etcetera in order to
get the right database mode.

Originally, pseudo assumed that the "correct" mode for
a file would be the mode returned by creating the file with the
requested mode. Over time, that's been fixed up to include
masking in 0600 bits, and 0100 for directories, and masking out
022 bits, then restoring these bits from the specified mode...
Which doesn't produce the right results if umask has any of 0722
in it. Which it often does.

The patch sent out earlier today got this right for plain files and
special nodes, but not for directories, unless you were building on
RHEL4 or another system which doesn't actually have the *at() functions.

The following changes since commit 9948e4239b88026804c33d84830dbfe6b0ed3e59:

  eglinfo: updated to compile with mesa10+ (2014-05-27 16:10:25 +0100)

are available in the git repository at:
  git://git.yoctoproject.org/poky-contrib seebs/umask
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/umask

Peter Seebach (1):
  pseudo: Honor umask again

 .../pseudo/files/pseudo-fchmodat-permissions.patch |  169 +++++++++++++++++++-
 1 files changed, 163 insertions(+), 6 deletions(-)



             reply	other threads:[~2014-05-28  0:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-28  0:14 Peter Seebach [this message]
2014-05-28  0:14 ` [PATCH 1/1] pseudo: Honor umask again Peter Seebach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1401235888.git.peter.seebach@windriver.com \
    --to=peter.seebach@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox