From: Peter Seebach <peter.seebach@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH 0/1] Make "set -x" in postinst scripts not break rootfs
Date: Thu, 21 May 2015 15:36:34 -0500 [thread overview]
Message-ID: <cover.1432240437.git.peter.seebach@windriver.com> (raw)
I was trying to debug a postinstall script, so I added set -x, so rootfs
creation broke. The issue is that set -x caused lines of code to be emitted
in a place where the log file checker saw them. It's totally okay for
a postinstall script to exit 1; that moves it into etc/rpm-postinsts, and
then it runs on the target.
So it shouldn't prevent rootfs creation from "succeeding". Solution: Don't
process lines preceeded by a "+", because that's probably set -x output.
The following changes since commit fe7780a9bbbfa4dcbbe457618a0842e91a3c6a0e:
libxdmcp: make libbsd usage deterministic (2015-05-21 10:48:41 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib seebs/setminusx
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/setminusx
Peter Seebach (1):
rootfs.py: Make set -x not break rootfs creation
meta/lib/oe/rootfs.py | 3 +++
1 file changed, 3 insertions(+)
--
2.3.1
next reply other threads:[~2015-05-21 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 20:36 Peter Seebach [this message]
2015-05-21 20:36 ` [PATCH 1/1] rootfs.py: Make set -x not break rootfs creation Peter Seebach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1432240437.git.peter.seebach@windriver.com \
--to=peter.seebach@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox