[PATCH 0/1] recipetool/create.py: fix LICENSE value

[PATCH 0/1] recipetool/create.py: fix LICENSE value

[Chen Qi]

The following changes since commit 7b4b67da33beff736dc0286ea24e3860480f9650:

  directfb: fix client->gfx_state initialisation (2016-06-15 18:13:09 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib ChenQi/recipetool-license
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/recipetool-license

Chen Qi (1):
  recipetool/create.py: fix LICENSE value

 scripts/lib/recipetool/create.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/1] recipetool/create.py: fix LICENSE value

[Chen Qi]

When there multiple license in a repo, the LICENSE value be created as
something like "LGPLv2.1 GPLv2", which causes the following warning.

LICENSE value "LGPLv2.1 GPLv2" has an invalid format - license names must
be separated by the following characters to indicate the license selection: &|()

Fix it by using '&' to join multiple licenses.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 scripts/lib/recipetool/create.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/recipetool/create.py b/scripts/lib/recipetool/create.py
index 1297428..b3fd78b 100644
--- a/scripts/lib/recipetool/create.py
+++ b/scripts/lib/recipetool/create.py
@@ -504,7 +504,7 @@ def create_recipe(args):
             licenses = [pkg_license]
         else:
             lines_before.append('# NOTE: Original package metadata indicates license is: %s' % pkg_license)
-    lines_before.append('LICENSE = "%s"' % ' '.join(licenses))
+    lines_before.append('LICENSE = "%s"' % ' & '.join(licenses))
     lines_before.append('LIC_FILES_CHKSUM = "%s"' % ' \\\n                    '.join(lic_files_chksum))
     lines_before.append('')
 
-- 
1.9.1

Re: [PATCH 1/1] recipetool/create.py: fix LICENSE value

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

On 16 June 2016 at 10:30, Chen Qi <Qi.Chen@windriver.com> wrote:

> When there multiple license in a repo, the LICENSE value be created as
> something like "LGPLv2.1 GPLv2", which causes the following warning.
>
> LICENSE value "LGPLv2.1 GPLv2" has an invalid format - license names must
> be separated by the following characters to indicate the license
> selection: &|()
>
> Fix it by using '&' to join multiple licenses.
>

This behaviour is intentional, as recipetool isn't smart enough to read the
licensing terms and decide if there are multiple licenses in aggregate (&)
or a choice of licenses (|).  The solution is to list all the licenses that
have been found, let bitbake throw a warning, and the person creating a
recipe comprehend the licensing situation and add the relevant operations.

Ross

[-- Attachment #2: Type: text/html, Size: 1286 bytes --]

Re: [PATCH 1/1] recipetool/create.py: fix LICENSE value

[ChenQi]

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

On 06/22/2016 06:57 PM, Burton, Ross wrote:
>
> On 16 June 2016 at 10:30, Chen Qi <Qi.Chen@windriver.com 
> <mailto:Qi.Chen@windriver.com>> wrote:
>
>     When there multiple license in a repo, the LICENSE value be created as
>     something like "LGPLv2.1 GPLv2", which causes the following warning.
>
>     LICENSE value "LGPLv2.1 GPLv2" has an invalid format - license
>     names must
>     be separated by the following characters to indicate the license
>     selection: &|()
>
>     Fix it by using '&' to join multiple licenses.
>
>
> This behaviour is intentional, as recipetool isn't smart enough to 
> read the licensing terms and decide if there are multiple licenses in 
> aggregate (&) or a choice of licenses (|).  The solution is to list 
> all the licenses that have been found, let bitbake throw a warning, 
> and the person creating a recipe comprehend the licensing situation 
> and add the relevant operations.
>
> Ross

Thanks for your detailed explanation.

Best Regards,
Chen Qi

[-- Attachment #2: Type: text/html, Size: 2329 bytes --]