public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 0/1] Avoid race in perform_groupmems()
Date: Thu, 15 Sep 2016 17:44:46 +0200	[thread overview]
Message-ID: <cover.1473954220.git.pkj@axis.com> (raw)

We have seen sporadic failures in our CI builds due to useradd,
groupadd or groupmems failing. I have now tracked it down to
perform_groupmems() in useradd_base.bbclass, where I found code to
temporarily create the /etc/gshadow file in the sysroot if it did not
exist. Purportedly this was due to groupmems requiring the gshadow
file to exist. There are, however, no real evidence of that
requirement, and actually creating and removing the file the way it is
currently done WILL cause failures when one task removes it while
another task expects it to already exist.

//Peter

The following changes since commit 53b1fa2d3e1244c46a705d9a40ca0dbee92eab98:

  bitbake: build: Allow dirs/cleandirs to work for empty functions (2016-09-15 12:15:07 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib pkj/groupmems
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/groupmems

Peter Kjellerstedt (1):
  useradd_base.bbclass: Do not mess with the gshadow file in the sysroot

 meta/classes/useradd_base.bbclass | 12 ------------
 1 file changed, 12 deletions(-)

-- 
2.9.0



             reply	other threads:[~2016-09-15 15:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 15:44 Peter Kjellerstedt [this message]
2016-09-15 15:44 ` [PATCH 1/1] useradd_base.bbclass: Do not mess with the gshadow file in the sysroot Peter Kjellerstedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1473954220.git.pkj@axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox